-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Section 508 accessibility issue with underlying Canvas element with no name. #14437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@brendandahl Is this somewhat expected after PR #13118 (which removed the "aria-label" on the canvas-elements), or is that not entirely relevant here? |
@Snuffleupagus appreciate the quick response to this issue. We are hoping for a quick turn-around since this one minor issue puts the whole thing out of compliance for Section 508 accessibility. |
@MReschenberg is this something you could help us with? In #13118 we removed the aria-label from the canvas as it was not needed anymore (see discussion at #13118 (comment) for the reason). |
Maybe we can set "aria-labelledby" on the canvas to point to the div that contains it? |
What's the semantic use of the |
has the viewer at https://mozilla.github.io/pdf.js/web/viewer.html been updated with this change? i still get the same accessibility name issue. |
@MReschenberg it looks like this ANDI tool from the US government considers the |
I wonder if this isn't a bug in the ANDI tool... |
Yes, I think so, I even tried with an empty page with just the canvas and role presentation and ANDI is still complaining. Probably it isn't taking into account the role. @rgutierrezatx do you have a way to report this problem to the ANDI developers? |
I filed SSAgov/ANDI#138 on the ANDI GitHub repo. |
ANDI resolved the issue in their tooling and closed your ticket. thanks! |
Configuration:
Steps to reproduce the problem:
What is the expected behavior? the underlying Canvas should have an accessible name
What went wrong? see screenshot for the error. A name should be set or at least allow us to set this name
The text was updated successfully, but these errors were encountered: