Skip to content

Crashes/timeouts on freshly fuzzed files #14305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tballison opened this issue Nov 24, 2021 · 4 comments
Closed

Crashes/timeouts on freshly fuzzed files #14305

tballison opened this issue Nov 24, 2021 · 4 comments

Comments

@tballison
Copy link

tballison commented Nov 24, 2021

On #14303, I shared unmodified files from our bug tracker corpus that appeared to cause some problems for pdf.js. On this issue, I'll attach files that are freshly fuzzed using files from that corpus as seeds. I avoided files used in #14303 as seeds for these runs

I haven't done root cause analysis, and I apologize if these are all just triggering the same underlying bug (or that fixed in #14304). The files are named for their seed file and then the sha-256 of the fuzzed version.

new-nasties.zip

@tballison
Copy link
Author

tballison commented Nov 24, 2021

Unrelated sidenote...omg, github accepts or rejects files based solely on their file suffix, and it doesn't recognize tgz?! Ommm... So maybe, I'll just throw a .pdf on the end of the tgz file that github didn't like... 🤮
new-nasties.tgz.pdf

@Snuffleupagus
Copy link
Collaborator

new-nasties.zip
new-nasties.tgz.pdf

All those documents seem to "work" more-or-less about as good as can be expected, when testing with an up-to-date PDF.js version, given that we're dealing with various kinds of corrupt PDF documents.

Let's close this as a duplicate of #14303 for now, since that one likely covers any remaining problems already.

@tballison
Copy link
Author

tballison commented Nov 30, 2021

I've rebuilt from master, and I'm finding that fuzzing the bugtracker corpus is still yielding some files that cause crashes (exitValue=1) and timeouts (e.g. a 2kb file timing out at 3 minutes). My goal is not to annoy you. If you'd like to see the new files, please let me know where I should hang them (this ticket or #14303 or another).

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Nov 30, 2021

If you'd like to see the new files, please let me know where I should hang them (this ticket or #14303 or another).

Adding them to the open issue, i.e. 14303, seems fine assuming they're indeed "new" problems.
But, please attach the PDF documents directly rather than using e.g. zip-files.


I've not had time to go all the remaining ones in 14303 in detail, but I believe that there's basically three categories: Bugs already tracked elsewhere, documents which work fine in the viewer (note that Node.js performs worse e.g. on account of no Worker-support), and documents which are so ridiculously huge that it doesn't make much sense to worry about them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants