Skip to content

Commit b10a314

Browse files
committed
[GENERIC viewer] Try to improve a11y, for search results, in the findbar (issue 14525)
The following MDN articles may be helpful here: - https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-invalid - https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-live
1 parent 54d4d34 commit b10a314

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

web/pdf_find_bar.js

+1
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ class PDFFindBar {
127127
break;
128128
}
129129
this.findField.setAttribute("data-status", status);
130+
this.findField.setAttribute("aria-invalid", state === FindState.NOT_FOUND);
130131

131132
findMsg.then(msg => {
132133
this.findMsg.textContent = msg;

web/viewer.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@
116116
<div id="mainContainer">
117117
<div class="findbar hidden doorHanger" id="findbar">
118118
<div id="findbarInputContainer">
119-
<input id="findInput" class="toolbarField" title="Find" placeholder="Find in document…" tabindex="91" data-l10n-id="find_input">
119+
<input id="findInput" class="toolbarField" title="Find" placeholder="Find in document…" tabindex="91" data-l10n-id="find_input" aria-invalid="false">
120120
<div class="splitToolbarButton">
121121
<button id="findPrevious" class="toolbarButton findPrevious" title="Find the previous occurrence of the phrase" tabindex="92" data-l10n-id="find_previous">
122122
<span data-l10n-id="find_previous_label">Previous</span>
@@ -141,10 +141,10 @@
141141
<label for="findEntireWord" class="toolbarLabel" data-l10n-id="find_entire_word_label">Whole Words</label>
142142
</div>
143143

144-
<div class="findbarMessageContainer">
144+
<div class="findbarMessageContainer" aria-live="polite">
145145
<span id="findResultsCount" class="toolbarLabel"></span>
146146
</div>
147-
<div class="findbarMessageContainer">
147+
<div class="findbarMessageContainer" aria-live="assertive">
148148
<span id="findMsg" class="toolbarLabel"></span>
149149
</div>
150150
</div> <!-- findbar -->

0 commit comments

Comments
 (0)