Skip to content

Commit 96366e1

Browse files
committed
Remove unnecessary CSS classes when specifying button icons
Currently we're using *both* ids and classes when specifying the button icons, which seems completely unnecessary and only serves to bloat the CSS code. In general you always need to be careful about CSS specificity, but in these cases that's should not actually be a problem. Also, while not a button, this patch makes a similar simplification for the `pageNumber`-input.
1 parent 14ea46d commit 96366e1

File tree

1 file changed

+42
-42
lines changed

1 file changed

+42
-42
lines changed

web/viewer.css

+42-42
Original file line numberDiff line numberDiff line change
@@ -772,57 +772,57 @@ select {
772772
inset-inline-start: 12px;
773773
}
774774

775-
.toolbarButton#sidebarToggle::before {
775+
#sidebarToggle::before {
776776
mask-image: var(--toolbarButton-sidebarToggle-icon);
777777
transform: scaleX(var(--dir-factor));
778778
}
779779

780-
.toolbarButton#secondaryToolbarToggle::before {
780+
#secondaryToolbarToggle::before {
781781
mask-image: var(--toolbarButton-secondaryToolbarToggle-icon);
782782
transform: scaleX(var(--dir-factor));
783783
}
784784

785-
#findPrevious.toolbarButton::before {
785+
#findPrevious::before {
786786
mask-image: var(--findbarButton-previous-icon);
787787
}
788788

789-
#findNext.toolbarButton::before {
789+
#findNext::before {
790790
mask-image: var(--findbarButton-next-icon);
791791
}
792792

793-
.toolbarButton#previous::before {
793+
#previous::before {
794794
mask-image: var(--toolbarButton-pageUp-icon);
795795
}
796796

797-
.toolbarButton#next::before {
797+
#next::before {
798798
mask-image: var(--toolbarButton-pageDown-icon);
799799
}
800800

801-
.toolbarButton#zoomOut::before {
801+
#zoomOut::before {
802802
mask-image: var(--toolbarButton-zoomOut-icon);
803803
}
804804

805-
.toolbarButton#zoomIn::before {
805+
#zoomIn::before {
806806
mask-image: var(--toolbarButton-zoomIn-icon);
807807
}
808808

809-
.toolbarButton#presentationMode::before,
810-
.secondaryToolbarButton#secondaryPresentationMode::before {
809+
#presentationMode::before,
810+
#secondaryPresentationMode::before {
811811
mask-image: var(--toolbarButton-presentationMode-icon);
812812
}
813813

814-
.toolbarButton#print::before,
815-
.secondaryToolbarButton#secondaryPrint::before {
814+
#print::before,
815+
#secondaryPrint::before {
816816
mask-image: var(--toolbarButton-print-icon);
817817
}
818818

819-
.toolbarButton#openFile::before, /* -webkit-non-mozcentral */
820-
.secondaryToolbarButton#secondaryOpenFile::before /* -webkit-non-mozcentral */ {
819+
#openFile::before, /* -webkit-non-mozcentral */
820+
#secondaryOpenFile::before /* -webkit-non-mozcentral */ {
821821
mask-image: var(--toolbarButton-openFile-icon);
822822
}
823823

824-
.toolbarButton#download::before,
825-
.secondaryToolbarButton#secondaryDownload::before {
824+
#download::before,
825+
#secondaryDownload::before {
826826
mask-image: var(--toolbarButton-download-icon);
827827
}
828828

@@ -836,38 +836,38 @@ a.secondaryToolbarButton {
836836
text-decoration: none;
837837
}
838838

839-
.toolbarButton#viewBookmark::before,
840-
.secondaryToolbarButton#secondaryViewBookmark::before {
839+
#viewBookmark::before,
840+
#secondaryViewBookmark::before {
841841
mask-image: var(--toolbarButton-bookmark-icon);
842842
}
843843

844-
#viewThumbnail.toolbarButton::before {
844+
#viewThumbnail::before {
845845
mask-image: var(--toolbarButton-viewThumbnail-icon);
846846
}
847847

848-
#viewOutline.toolbarButton::before {
848+
#viewOutline::before {
849849
mask-image: var(--toolbarButton-viewOutline-icon);
850850
transform: scaleX(var(--dir-factor));
851851
}
852852

853-
#viewAttachments.toolbarButton::before {
853+
#viewAttachments::before {
854854
mask-image: var(--toolbarButton-viewAttachments-icon);
855855
}
856856

857-
#viewLayers.toolbarButton::before {
857+
#viewLayers::before {
858858
mask-image: var(--toolbarButton-viewLayers-icon);
859859
}
860860

861-
#currentOutlineItem.toolbarButton::before {
861+
#currentOutlineItem::before {
862862
mask-image: var(--toolbarButton-currentOutlineItem-icon);
863863
transform: scaleX(var(--dir-factor));
864864
}
865865

866-
#viewFind.toolbarButton::before {
866+
#viewFind::before {
867867
mask-image: var(--toolbarButton-search-icon);
868868
}
869869

870-
.toolbarButton.pdfSidebarNotification::after {
870+
.pdfSidebarNotification::after {
871871
position: absolute;
872872
display: inline-block;
873873
top: 1px;
@@ -898,59 +898,59 @@ a.secondaryToolbarButton {
898898
padding-inline-end: 4px;
899899
}
900900

901-
.secondaryToolbarButton#firstPage::before {
901+
#firstPage::before {
902902
mask-image: var(--secondaryToolbarButton-firstPage-icon);
903903
}
904904

905-
.secondaryToolbarButton#lastPage::before {
905+
#lastPage::before {
906906
mask-image: var(--secondaryToolbarButton-lastPage-icon);
907907
}
908908

909-
.secondaryToolbarButton#pageRotateCcw::before {
909+
#pageRotateCcw::before {
910910
mask-image: var(--secondaryToolbarButton-rotateCcw-icon);
911911
}
912912

913-
.secondaryToolbarButton#pageRotateCw::before {
913+
#pageRotateCw::before {
914914
mask-image: var(--secondaryToolbarButton-rotateCw-icon);
915915
}
916916

917-
.secondaryToolbarButton#cursorSelectTool::before {
917+
#cursorSelectTool::before {
918918
mask-image: var(--secondaryToolbarButton-selectTool-icon);
919919
}
920920

921-
.secondaryToolbarButton#cursorHandTool::before {
921+
#cursorHandTool::before {
922922
mask-image: var(--secondaryToolbarButton-handTool-icon);
923923
}
924924

925-
.secondaryToolbarButton#scrollPage::before {
925+
#scrollPage::before {
926926
mask-image: var(--secondaryToolbarButton-scrollPage-icon);
927927
}
928928

929-
.secondaryToolbarButton#scrollVertical::before {
929+
#scrollVertical::before {
930930
mask-image: var(--secondaryToolbarButton-scrollVertical-icon);
931931
}
932932

933-
.secondaryToolbarButton#scrollHorizontal::before {
933+
#scrollHorizontal::before {
934934
mask-image: var(--secondaryToolbarButton-scrollHorizontal-icon);
935935
}
936936

937-
.secondaryToolbarButton#scrollWrapped::before {
937+
#scrollWrapped::before {
938938
mask-image: var(--secondaryToolbarButton-scrollWrapped-icon);
939939
}
940940

941-
.secondaryToolbarButton#spreadNone::before {
941+
#spreadNone::before {
942942
mask-image: var(--secondaryToolbarButton-spreadNone-icon);
943943
}
944944

945-
.secondaryToolbarButton#spreadOdd::before {
945+
#spreadOdd::before {
946946
mask-image: var(--secondaryToolbarButton-spreadOdd-icon);
947947
}
948948

949-
.secondaryToolbarButton#spreadEven::before {
949+
#spreadEven::before {
950950
mask-image: var(--secondaryToolbarButton-spreadEven-icon);
951951
}
952952

953-
.secondaryToolbarButton#documentProperties::before {
953+
#documentProperties::before {
954954
mask-image: var(--secondaryToolbarButton-documentProperties-icon);
955955
}
956956

@@ -991,18 +991,18 @@ a.secondaryToolbarButton {
991991
margin-inline-start: 7px;
992992
}
993993

994-
.toolbarField#pageNumber {
994+
#pageNumber {
995995
-moz-appearance: textfield; /* hides the spinner in moz */
996996
text-align: right;
997997
width: 40px;
998998
}
999-
.toolbarField#pageNumber.visiblePageIsLoading {
999+
#pageNumber.visiblePageIsLoading {
10001000
background-image: var(--loading-icon);
10011001
background-repeat: no-repeat;
10021002
background-position: 3px;
10031003
}
10041004

1005-
.toolbarField#pageNumber::-webkit-inner-spin-button {
1005+
#pageNumber::-webkit-inner-spin-button {
10061006
-webkit-appearance: none;
10071007
}
10081008

0 commit comments

Comments
 (0)