XFA - Elements created outside of XML must have all their properties (bug 1722029)

  - an Image element was created, attached to its parent but the $globalData property was not set and that led to an error.
  - the pdf in bug 1722029 has 27 rendered rows (checked in Acrobat) when only one was displayed: this patch some binding issues around the occur element.

Author: calixteman

src/core/xfa/bind.js

@@ -37,6 +37,7 @@ import {
   $setValue,
   $text,
   XFAAttribute,
+  XFAObjectArray,
   XmlObject,
 } from "./xfa_object.js";
 import { BindItems, Field, Items, SetProperty, Text } from "./template.js";
@@ -391,25 +392,39 @@ class Binder {
     // Insert nodes which are not in the template but reflect
     // what we've in data tree.
 
-    let baseClone;
-    if (matches.length > 1) {
-      // Clone before binding to avoid bad state.
-      baseClone = formNode[$clone]();
+    const parent = formNode[$getParent]();
+    const name = formNode[$nodeName];
+    // Clone before binding to avoid bad state.
+    const baseClone = formNode[$clone]();
+
+    if (!(parent[name] instanceof XFAObjectArray)) {
+      this._bindValue(formNode, matches[0], picture);
+      this._setProperties(formNode, matches[0]);
+      this._bindItems(formNode, matches[0]);
+      return;
     }
 
-    this._bindValue(formNode, matches[0], picture);
-    this._setProperties(formNode, matches[0]);
-    this._bindItems(formNode, matches[0]);
+    let i = 0;
+    for (const child of parent[name].children) {
+      if (child.name !== formNode.name) {
+        continue;
+      }
+      if (i === matches.length) {
+        break;
+      }
+      const match = matches[i++];
+      this._bindValue(child, match, picture);
+      this._setProperties(child, match);
+      this._bindItems(child, match);
+    }
 
-    if (matches.length === 1) {
+    if (i >= matches.length) {
       return;
     }
 
-    const parent = formNode[$getParent]();
-    const name = formNode[$nodeName];
     const pos = parent[$indexOf](formNode);
 
-    for (let i = 1, ii = matches.length; i < ii; i++) {
+    for (const ii = matches.length; i < ii; i++) {
       const match = matches[i];
       const clone = baseClone[$clone]();
       clone.occur.min = 1;
@@ -425,10 +440,6 @@ class Binder {
   }
 
   _createOccurrences(formNode) {
-    if (!this.emptyMerge) {
-      return;
-    }
-
     const { occur } = formNode;
     if (!occur || occur.initial <= 1) {
       return;
@@ -437,13 +448,27 @@ class Binder {
     const parent = formNode[$getParent]();
     const name = formNode[$nodeName];
 
-    for (let i = 0, ii = occur.initial; i < ii; i++) {
+    if (!(parent[name] instanceof XFAObjectArray)) {
+      return;
+    }
+
+    let currentNumber;
+    if (formNode.name) {
+      currentNumber = parent[name].children.filter(
+        e => e.name === formNode.name
+      ).length;
+    } else {
+      currentNumber = parent[name].children.length;
+    }
+
+    const pos = parent[$indexOf](formNode) + 1;
+    for (let i = 0, ii = occur.initial - currentNumber; i < ii; i++) {
       const clone = formNode[$clone]();
       clone.occur.min = 1;
       clone.occur.max = 1;
       clone.occur.initial = 1;
       parent[name].push(clone);
-      parent[$appendChild](clone);
+      parent[$insertAt](pos + i, clone);
     }
   }
 
@@ -629,12 +654,6 @@ class Binder {
       }
 
       if (match) {
-        if (match.length < min) {
-          warn(
-            `XFA - Must have at least ${min} occurrences: ${formNode[$nodeName]}.`
-          );
-          continue;
-        }
         this._bindOccurrences(child, match, picture);
       } else if (min > 0) {
         this._setProperties(child, dataNode);

src/core/xfa/template.js

@@ -3605,7 +3605,7 @@ class Occur extends XFAObject {
     this.id = attributes.id || "";
     this.initial = getInteger({
       data: attributes.initial,
-      defaultValue: 1,
+      defaultValue: "",
       validate: x => true,
     });
     this.max = getInteger({
@@ -3622,6 +3622,12 @@ class Occur extends XFAObject {
     this.usehref = attributes.usehref || "";
     this.extras = null;
   }
+
+  [$clean]() {
+    if (this.initial === "") {
+      this.initial = this[$getParent]() instanceof Template ? 1 : this.min;
+    }
+  }
 }
 
 class Oid extends StringObject {
@@ -5705,6 +5711,7 @@ class Value extends XFAObject {
       if (parent.ui && parent.ui.imageEdit) {
         if (!this.image) {
           this.image = new Image({});
+          this[$appendChild](this.image);
         }
         this.image[$content] = value[$content];
         return;

src/core/xfa/xfa_object.js

@@ -204,6 +204,9 @@ class XFAObject {
   [$appendChild](child) {
     child[_parent] = this;
     this[_children].push(child);
+    if (!child[$globalData] && this[$globalData]) {
+      child[$globalData] = this[$globalData];
+    }
   }
 
   [$removeChild](child) {
@@ -236,6 +239,9 @@ class XFAObject {
   [$insertAt](i, child) {
     child[_parent] = this;
     this[_children].splice(i, 0, child);
+    if (!child[$globalData] && this[$globalData]) {
+      child[$globalData] = this[$globalData];
+    }
   }
 
   /**

test/pdfs/xfa_bug1722029.pdf.link

@@ -0,0 +1 @@
+https://bugzilla.mozilla.org/attachment.cgi?id=9233058

test/test_manifest.json

@@ -952,6 +952,14 @@
        "enableXfa": true,
        "type": "eq"
     },
+    {  "id": "xfa_bug1722029",
+       "file": "pdfs/xfa_bug1722029.pdf",
+       "md5": "d8dd6bb20599fc777b4c7ff7b74dd5e3",
+       "link": true,
+       "rounds": 1,
+       "enableXfa": true,
+       "type": "eq"
+    },
     {  "id": "xfa_bug1721600",
        "file": "pdfs/xfa_bug1721600.pdf",
        "md5": "5f514f476169eeb7254da380a8db495a",