Skip to content

Commit 7dda856

Browse files
committed
[UI] Avoid to have buttons in hover state after having been clicked (bug 836732)
- it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=836732; - replace :focus by :focus-visible for the buttons in the UI, according to the docs: - https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible - the button has the focus-visible state when it has been focused with the keyboard
1 parent 7a03470 commit 7dda856

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

web/viewer.css

+11-11
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ html[dir="rtl"] .findbar .splitToolbarButton > .findNext {
559559
}
560560

561561
.findbar label:hover,
562-
.findbar input:focus + label {
562+
.findbar input:focus-visible + label {
563563
color: var(--toggled-btn-color);
564564
background-color: var(--button-hover-color);
565565
}
@@ -753,12 +753,12 @@ html[dir="rtl"] .splitToolbarButton > .toolbarButton {
753753
}
754754

755755
.overlayButton:hover,
756-
.overlayButton:focus {
756+
.overlayButton:focus-visible {
757757
background-color: var(--overlay-button-hover-bg-color);
758758
}
759759

760760
.overlayButton:hover > span,
761-
.overlayButton:focus > span {
761+
.overlayButton:focus-visible > span {
762762
color: var(--overlay-button-hover-color);
763763
}
764764

@@ -780,10 +780,10 @@ html[dir="rtl"] .splitToolbarButton > .toolbarButton {
780780
}
781781

782782
.splitToolbarButton > .toolbarButton:hover,
783-
.splitToolbarButton > .toolbarButton:focus,
783+
.splitToolbarButton > .toolbarButton:focus-visible,
784784
.dropdownToolbarButton:hover,
785785
.toolbarButton.textButton:hover,
786-
.toolbarButton.textButton:focus {
786+
.toolbarButton.textButton:focus-visible {
787787
background-color: var(--button-hover-color);
788788
z-index: 199;
789789
}
@@ -847,11 +847,11 @@ html[dir="rtl"] #toolbarViewerLeft > .toolbarButton:first-child {
847847
margin-right: 2px;
848848
}
849849
.toolbarButton:hover,
850-
.toolbarButton:focus {
850+
.toolbarButton:focus-visible {
851851
background-color: var(--button-hover-color);
852852
}
853853
.secondaryToolbarButton:hover,
854-
.secondaryToolbarButton:focus {
854+
.secondaryToolbarButton:focus-visible {
855855
background-color: var(--doorhanger-hover-bg-color);
856856
color: var(--doorhanger-hover-color);
857857
}
@@ -917,7 +917,7 @@ html[dir="rtl"] .dropdownToolbarButton > select {
917917
padding-right: 4px;
918918
}
919919
.dropdownToolbarButton > select:hover,
920-
.dropdownToolbarButton > select:focus {
920+
.dropdownToolbarButton > select:focus-visible {
921921
background-color: var(--button-hover-color);
922922
color: var(--toggled-btn-color);
923923
}
@@ -959,7 +959,7 @@ html[dir="rtl"] .dropdownToolbarButton > select {
959959
}
960960

961961
.dropdownToolbarButton:hover::after,
962-
.dropdownToolbarButton:focus::after,
962+
.dropdownToolbarButton:focus-visible::after,
963963
.dropdownToolbarButton:active::after {
964964
background-color: var(--toolbar-icon-hover-bg-color);
965965
}
@@ -971,9 +971,9 @@ html[dir="rtl"] .dropdownToolbarButton > select {
971971
}
972972

973973
.toolbarButton:hover::before,
974-
.toolbarButton:focus::before,
974+
.toolbarButton:focus-visible::before,
975975
.secondaryToolbarButton:hover::before,
976-
.secondaryToolbarButton:focus::before {
976+
.secondaryToolbarButton:focus-visible::before {
977977
background-color: var(--toolbar-icon-hover-bg-color);
978978
}
979979

0 commit comments

Comments
 (0)