Add an empty entry in combo list when nothing is selected (bug 1773680)

- it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1773680
- the empty is removed once something is selected.

Author: calixteman

src/display/annotation_layer.js

@@ -1461,6 +1461,8 @@ class ChoiceWidgetAnnotationElement extends WidgetAnnotationElement {
     selectElement.setAttribute("id", id);
     selectElement.tabIndex = DEFAULT_TAB_INDEX;
 
+    let hasAnEmptyEntry = true;
+
     if (!this.data.combo) {
       // List boxes have a size and (optionally) multiple selection.
       selectElement.size = this.data.options.length;
@@ -1486,10 +1488,21 @@ class ChoiceWidgetAnnotationElement extends WidgetAnnotationElement {
       }
       if (storedData.value.includes(option.exportValue)) {
         optionElement.setAttribute("selected", true);
+        hasAnEmptyEntry = false;
       }
       selectElement.appendChild(optionElement);
     }
 
+    if (hasAnEmptyEntry && this.data.combo && this.data.options) {
+      const noneOptionElement = document.createElement("option");
+      noneOptionElement.value = " ";
+      noneOptionElement.setAttribute("hidden", true);
+      selectElement.insertBefore(noneOptionElement, selectElement.firstChild);
+      noneOptionElement.setAttribute("selected", true);
+    } else {
+      hasAnEmptyEntry = false;
+    }
+
     const getValue = (event, isExport) => {
       const name = isExport ? "value" : "textContent";
       const options = event.target.options;
@@ -1602,6 +1615,10 @@ class ChoiceWidgetAnnotationElement extends WidgetAnnotationElement {
       });
 
       selectElement.addEventListener("input", event => {
+        if (hasAnEmptyEntry) {
+          selectElement.firstChild.remove();
+          hasAnEmptyEntry = false;
+        }
         const exportValue = getValue(event, /* isExport */ true);
         const value = getValue(event, /* isExport */ false);
         storage.setValue(id, { value: exportValue });

test/pdfs/bug1773680.pdf.link

@@ -0,0 +1,2 @@
+https://bugzilla.mozilla.org/attachment.cgi?id=9280675
+

test/test_manifest.json

@@ -6567,5 +6567,13 @@
       "rounds": 1,
       "type": "eq",
       "annotations": true
+   },
+   {  "id": "bug1773680.pdf",
+      "file": "pdfs/bug1773680.pdf",
+      "md5": "6099fc695fe018ce444752929d86f9c8",
+      "rounds": 1,
+      "link": true,
+      "type": "eq",
+      "annotations": true
    }
 ]