Skip to content

Commit 2a399c1

Browse files
committed
Revert "Disable the browser-tests, during gulp makeref, in Google Chrome on the Windows bot (PR 14392 follow-up)"
This reverts commit 18c295f. The most recent Puppeteer version ships with the most recent Chrome version that should fix the problems we encountered before.
1 parent a96115e commit 2a399c1

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

gulpfile.js

+1-8
Original file line numberDiff line numberDiff line change
@@ -612,18 +612,11 @@ function makeRef(done, bot) {
612612
console.log();
613613
console.log("### Creating reference images");
614614

615-
let forceNoChrome = false;
616615
const args = ["test.js", "--masterMode"];
617616
if (bot) {
618-
const os = process.env.OS;
619-
if (/windows/i.test(os)) {
620-
// The browser-tests are too slow in Google Chrome on the Windows
621-
// bot, causing a timeout, hence disabling them for now.
622-
forceNoChrome = true;
623-
}
624617
args.push("--noPrompts", "--strictVerify");
625618
}
626-
if (process.argv.includes("--noChrome") || forceNoChrome) {
619+
if (process.argv.includes("--noChrome")) {
627620
args.push("--noChrome");
628621
}
629622

0 commit comments

Comments
 (0)