Skip to content

Commit 2a35b39

Browse files
committed
Remove the unused dataset checks from the scrollIntoView helper function
This code was added in PR 3968, apparently in order to fix scrolling of search results in HiDPI-mode. However, after PR 4570 nothing is setting these `dataset`-properties any more and this is thus dead code which should be removed. (If that change had broken scrolling of search results in HiDPI-mode, you'd really expect that it'd been reported and fixed a long time ago.)
1 parent 9165dc0 commit 2a35b39

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

web/ui_utils.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -117,12 +117,9 @@ function scrollIntoView(element, spot, skipOverflowHiddenElements = false) {
117117
(skipOverflowHiddenElements &&
118118
getComputedStyle(parent).overflow === "hidden")
119119
) {
120-
if (parent.dataset._scaleY) {
121-
offsetY /= parent.dataset._scaleY;
122-
offsetX /= parent.dataset._scaleX;
123-
}
124120
offsetY += parent.offsetTop;
125121
offsetX += parent.offsetLeft;
122+
126123
parent = parent.offsetParent;
127124
if (!parent) {
128125
return; // no need to scroll

0 commit comments

Comments
 (0)