Merge pull request #12153 from timvandermeij/jasmine

Unit test improvements

Author: timvandermeij

package-lock.json

@@ -32,7 +32,7 @@
     "gulp-rename": "^1.4.0",
     "gulp-replace": "^1.0.0",
     "gulp-zip": "^4.2.0",
-    "jasmine": "~3.5.0",
+    "jasmine": "^3.6.1",
     "jsdoc": "^3.6.5",
     "jstransformer-markdown-it": "^2.1.0",
     "merge-stream": "^1.0.1",

package.json

@@ -48,21 +48,37 @@ var TestReporter = function (browser) {
 
   this.jasmineStarted = function (suiteInfo) {
     this.runnerStartTime = this.now();
-    sendInfo("Started tests for " + browser + ".");
+
+    const total = suiteInfo.totalSpecsDefined;
+    const seed = suiteInfo.order.seed;
+    sendInfo(`Started ${total} tests for ${browser} with seed ${seed}.`);
   };
 
-  this.suiteStarted = function (result) {};
+  this.suiteStarted = function (result) {
+    // Normally suite starts don't have to be reported because the individual
+    // specs inside them are reported, but it can happen that the suite cannot
+    // start, for instance due to an uncaught exception in `beforeEach`. This
+    // is problematic because the specs inside the suite will never be found
+    // and run, so if we don't report the suite start failure here it would be
+    // ignored silently, leading to passing tests even though some did not run.
+    if (result.failedExpectations.length > 0) {
+      let failedMessages = "";
+      for (const item of result.failedExpectations) {
+        failedMessages += `${item.message} `;
+      }
+      sendResult("TEST-UNEXPECTED-FAIL", result.description, failedMessages);
+    }
+  };
 
   this.specStarted = function (result) {};
 
   this.specDone = function (result) {
     if (result.failedExpectations.length === 0) {
       sendResult("TEST-PASSED", result.description);
     } else {
-      var failedMessages = "";
-      var items = result.failedExpectations;
-      for (var i = 0, ii = items.length; i < ii; i++) {
-        failedMessages += items[i].message + " ";
+      let failedMessages = "";
+      for (const item of result.failedExpectations) {
+        failedMessages += `${item.message} `;
       }
       sendResult("TEST-UNEXPECTED-FAIL", result.description, failedMessages);
     }
@@ -71,7 +87,7 @@ var TestReporter = function (browser) {
   this.suiteDone = function (result) {};
 
   this.jasmineDone = function () {
-    // Give the test.py some time process any queued up requests
+    // Give the test runner some time process any queued requests.
     setTimeout(sendQuitRequest, 500);
   };
 };