Annotation - For checkboxes, get field value from AS (if any) instead of V (bug 1722036)

  - it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1722036.
  - AS and V should share the same value for checkbox: it's at least what the specs say;
  - the pdf in the above bug opens correctly in Acrobat so it likely means that AS is chosen over V.

Author: calixteman

src/core/annotation.js

@@ -2083,6 +2083,12 @@ class ButtonWidgetAnnotation extends WidgetAnnotation {
       return;
     }
 
+    if (this.appearance) {
+      // See https://bugzilla.mozilla.org/show_bug.cgi?id=1722036
+      // If we've an AS and V then take AS.
+      this.data.fieldValue = this._decodeFormValue(params.dict.get("AS"));
+    }
+
     const exportValues = normalAppearance.getKeys();
     if (!exportValues.includes("Off")) {
       // The /Off appearance is optional.

test/pdfs/bug1722036.pdf.link

@@ -0,0 +1 @@
+https://bugzilla.mozilla.org/attachment.cgi?id=9232845

test/test_manifest.json

@@ -5899,5 +5899,12 @@
        "rounds": 1,
        "lastPage": 1,
        "type": "eq"
+    },
+    {  "id": "bug1722036",
+       "file": "pdfs/bug1722036.pdf",
+       "md5": "bbc7f62ca85609c97069bd3ce2658288",
+       "rounds": 1,
+        "link": true,
+       "type": "eq"
     }
 ]