Skip to content

Commit 699aa76

Browse files
committed
Bug 854315 - Display a banner to warn that validation of signatures is not supported in PDF files r=bdahl DONTBUILD
Thanks to PR: mozilla/pdf.js#13214 signatures in PDF will be displayed but they won't be validated. So display a banner to warn user about that. Differential Revision: https://phabricator.services.mozilla.com/D111540
1 parent c1d66ec commit 699aa76

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

toolkit/components/pdfjs/content/PdfStreamConverter.jsm

+2
Original file line numberDiff line numberDiff line change
@@ -583,6 +583,8 @@ class ChromeActions {
583583
var message;
584584
if (featureId === "forms") {
585585
message = getLocalizedString(strings, "unsupported_feature_forms");
586+
} else if (featureId === "signatures") {
587+
message = getLocalizedString(strings, "unsupported_feature_signatures");
586588
} else {
587589
message = getLocalizedString(strings, "unsupported_feature");
588590
}

toolkit/components/telemetry/Histograms.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10114,7 +10114,7 @@
1011410114
"releaseChannelCollection": "opt-out",
1011510115
"bug_numbers": [1630844, 1666979, 1689264],
1011610116
"kind": "categorical",
10117-
"labels": ["unknown", "forms", "javaScript", "smask", "shadingPattern", "font", "errorTilingPattern", "errorExtGState", "errorXObject", "errorFontLoadType3", "errorFontState", "errorFontMissing", "errorFontTranslate", "errorColorSpace", "errorOperatorList", "errorFontToUnicode", "errorFontLoadNative", "errorFontGetPath"],
10117+
"labels": ["unknown", "forms", "javaScript", "signatures", "smask", "shadingPattern", "font", "errorTilingPattern", "errorExtGState", "errorXObject", "errorFontLoadType3", "errorFontState", "errorFontMissing", "errorFontTranslate", "errorColorSpace", "errorOperatorList", "errorFontToUnicode", "errorFontLoadNative", "errorFontGetPath"],
1011810118
"description": "The reason the fallback bar was shown."
1011910119
},
1012010120
"PDF_VIEWER_FALLBACK_ERROR": {

0 commit comments

Comments
 (0)