Skip to content

Custom Watermarks #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ryanvall opened this issue Sep 14, 2020 · 2 comments · Fixed by #405
Closed

Custom Watermarks #404

ryanvall opened this issue Sep 14, 2020 · 2 comments · Fixed by #405

Comments

@ryanvall
Copy link
Contributor

ryanvall commented Sep 14, 2020 •
edited
Loading

Hello! Is there currently a built in way to customize istanbul's watermark thresholds? I tried applying the configuration in a few places but didn't have any luck. In doing some digging through the source I believe it needs specified when constructing the report context - which is passed into istanbul-lib-report.

If the above seems correct I can look into submitting a PR. Thanks for a great package!
@erikbarke
Copy link
Collaborator

Hey @ryanvall, a PR would be more than welcome!

@ryanvall ryanvall mentioned this issue Sep 16, 2020
Merged
@erikbarke
Copy link
Collaborator

@ryanvall, awesome!! 🚀

@snyk-bot snyk-bot mentioned this issue Mar 25, 2021
Open
@snyk-bot snyk-bot mentioned this issue May 30, 2021
Open
@Bhanditz Bhanditz mentioned this issue Jun 22, 2023
Open
@Bhanditz Bhanditz mentioned this issue Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom Watermark Thresholds topechelon/karma-typescript
2 participants
@erikbarke @ryanvall