Merge pull request #439 from vladjerca/fix/empty_subdirectory

erikbarke · web-flow · commit d8a89dd94277 · 2021-03-05T21:20:22.000+01:00
fix: use nullish coalescing for coverage directory paths
diff --git a/packages/karma-typescript/src/karma/reporter.ts b/packages/karma-typescript/src/karma/reporter.ts
@@ -106,12 +106,12 @@ export class Reporter {
     private getReportDestination(browser: any, reportConfig: any, reportType: any) {
 
         if (lodash.isPlainObject(reportConfig)) {
-            let subdirectory = reportConfig.subdirectory || browser.name;
+            let subdirectory = reportConfig.subdirectory ?? browser.name;
             if (typeof subdirectory === "function") {
                 subdirectory = subdirectory(browser);
             }
 
-            return path.join(reportConfig.directory || "coverage", subdirectory);
+            return path.join(reportConfig.directory ?? "coverage", subdirectory);
         }
 
         if (lodash.isString(reportConfig) && reportConfig.length > 0) {

Original file line number	Diff line number	Diff line change
`@@ -106,12 +106,12 @@ export class Reporter {`
`106`	`106`	`private getReportDestination(browser: any, reportConfig: any, reportType: any) {`
`107`	`107`
`108`	`108`	`if (lodash.isPlainObject(reportConfig)) {`
`109`		`- let subdirectory = reportConfig.subdirectory \|\| browser.name;`
	`109`	`+ let subdirectory = reportConfig.subdirectory ?? browser.name;`
`110`	`110`	`if (typeof subdirectory === "function") {`
`111`	`111`	`subdirectory = subdirectory(browser);`
`112`	`112`	`}`
`113`	`113`
`114`		`- return path.join(reportConfig.directory \|\| "coverage", subdirectory);`
	`114`	`+ return path.join(reportConfig.directory ?? "coverage", subdirectory);`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`if (lodash.isString(reportConfig) && reportConfig.length > 0) {`