INTMDB-448: custom_db_role error (#1009)

* example fix

* log to file add

* formating

* formatting updates

* Add mutex to prevent concurrent API calls datasource simplify count as it picks up other tests

Co-authored-by: Zuhair Ahmed <[email protected]>

Author: martinstibbe

mongodbatlas/data_source_mongodbatlas_custom_db_roles_test.go

@@ -37,7 +37,7 @@ func TestAccConfigDSCustomDBRoles_basic(t *testing.T) {
 
 					// Test for Data source
 					resource.TestCheckResourceAttrSet(dataSourceName, "project_id"),
-					resource.TestCheckResourceAttr(dataSourceName, "results.#", "1"),
+					resource.TestCheckResourceAttrSet(dataSourceName, "results.#"),
 				),
 			},
 		},

mongodbatlas/resource_mongodbatlas_custom_db_role.go

@@ -8,6 +8,7 @@ import (
 	"net/http"
 	"regexp"
 	"strings"
+	"sync"
 	"time"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
@@ -101,7 +102,13 @@ func resourceMongoDBAtlasCustomDBRole() *schema.Resource {
 	}
 }
 
+var (
+	customRoleLock sync.Mutex
+)
+
 func resourceMongoDBAtlasCustomDBRoleCreate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+	customRoleLock.Lock()
+	defer customRoleLock.Unlock()
 	conn := meta.(*MongoDBClient).Atlas
 	projectID := d.Get("project_id").(string)
 
@@ -180,6 +187,8 @@ func resourceMongoDBAtlasCustomDBRoleRead(ctx context.Context, d *schema.Resourc
 }
 
 func resourceMongoDBAtlasCustomDBRoleUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+	customRoleLock.Lock()
+	defer customRoleLock.Unlock()
 	conn := meta.(*MongoDBClient).Atlas
 	ids := decodeStateID(d.Id())
 	projectID := ids["project_id"]

mongodbatlas/resource_mongodbatlas_custom_db_role_test.go

@@ -412,7 +412,6 @@ func TestAccConfigRSCustomDBRoles_MultipleCustomRoles(t *testing.T) {
 }
 
 func TestAccConfigRSCustomDBRoles_MultipleResources(t *testing.T) {
-	t.Skip() // The error seems appear to be similar to whitelist behavior, skip it temporally
 	var (
 		resourceName = "mongodbatlas_custom_db_role.test"
 		projectID    = os.Getenv("MONGODB_ATLAS_PROJECT_ID")