JoinQuotedStrings

Author: lantoli

internal/service/advancedcluster/resource_advanced_cluster_test.go

@@ -2109,8 +2109,8 @@ func configAdvanced(t *testing.T, usePreviewProvider bool, projectID, clusterNam
 			tlsCipherConfigModeStr = fmt.Sprintf(`tls_cipher_config_mode = %[1]q`, *p.TlsCipherConfigMode)
 			if p.CustomOpensslCipherConfigTls12 != nil && len(*p.CustomOpensslCipherConfigTls12) > 0 {
 				customOpensslCipherConfigTLS12Str = fmt.Sprintf(
-					`custom_openssl_cipher_config_tls12 = [%q]`,
-					strings.Join(*p.CustomOpensslCipherConfigTls12, `", "`),
+					`custom_openssl_cipher_config_tls12 = [%s]`,
+					acc.JoinQuotedStrings(*p.CustomOpensslCipherConfigTls12),
 				)
 			}
 		}

internal/service/cluster/resource_cluster_test.go

@@ -4,7 +4,6 @@ import (
 	"fmt"
 	"os"
 	"regexp"
-	"strings"
 	"testing"
 	"time"
 
@@ -1473,8 +1472,8 @@ func configAdvancedConf(projectID, name, autoscalingEnabled string,
 		tlsCipherConfigModeStr = fmt.Sprintf(`tls_cipher_config_mode = %[1]q`, *p.TlsCipherConfigMode)
 		if p.CustomOpensslCipherConfigTls12 != nil && len(*p.CustomOpensslCipherConfigTls12) > 0 {
 			customOpensslCipherConfigTLS12Str = fmt.Sprintf(
-				`custom_openssl_cipher_config_tls12 = [%q]`,
-				strings.Join(*p.CustomOpensslCipherConfigTls12, `", "`),
+				`custom_openssl_cipher_config_tls12 = [%s]`,
+				acc.JoinQuotedStrings(*p.CustomOpensslCipherConfigTls12),
 			)
 		}
 	}
@@ -1577,8 +1576,8 @@ func configAdvancedConfPartial(projectID, name, autoscalingEnabled string, p *ad
 		tlsCipherConfigModeStr = fmt.Sprintf(`tls_cipher_config_mode = %[1]q`, *p.TlsCipherConfigMode)
 		if p.CustomOpensslCipherConfigTls12 != nil && len(*p.CustomOpensslCipherConfigTls12) > 0 {
 			customOpensslCipherConfigTLS12Str = fmt.Sprintf(
-				`custom_openssl_cipher_config_tls12 = [%q]`,
-				strings.Join(*p.CustomOpensslCipherConfigTls12, `", "`),
+				`custom_openssl_cipher_config_tls12 = [%s]`,
+				acc.JoinQuotedStrings(*p.CustomOpensslCipherConfigTls12),
 			)
 		}
 	}
@@ -1898,8 +1897,8 @@ func testAccMongoDBAtlasClusterAWSConfigdWithLabels(projectID, name, backupEnabl
 	for _, label := range labels {
 		labelsConf += fmt.Sprintf(`
 			labels {
-				key   = "%s"
-				value = "%s"
+				key   = %q
+				value = %q
 			}
 		`, label.Key, label.Value)
 	}

internal/testutil/acc/advanced_cluster.go

@@ -3,6 +3,7 @@ package acc
 import (
 	"context"
 	"fmt"
+	"strings"
 	"time"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry"
@@ -193,3 +194,11 @@ func PopulateWithSampleData(projectID, clusterName string) error {
 	_, err = stateConf.WaitForStateContext(ctx)
 	return err
 }
+
+func JoinQuotedStrings(list []string) string {
+	quoted := make([]string, len(list))
+	for i, item := range list {
+		quoted[i] = fmt.Sprintf("%q", item)
+	}
+	return strings.Join(quoted, ", ")
+}