DRIVERS-2884 Update retryable reads and writes to retry for network error on conn c/o

Author: prestonvasquez

.pre-commit-config.yaml

@@ -52,7 +52,7 @@ repos:
     entry: python3 scripts/check_md_html.py
 
 - repo: https://github.com/tcort/markdown-link-check
-  rev: v3.12.2
+  rev: v3.13.7
   hooks:
     - id: markdown-link-check
       args: ["-q", "-c", "markdown_link_config.json"]

README.md

@@ -36,14 +36,43 @@ To run a manual hook like `shellcheck` manually, run:
 pre-commit run --all-files --hook-stage manual shellcheck
 ```
 
-## Prose test numbering
+## Prose Test Numbering
 
 When numbering prose tests, always use relative numbered bullets (`1.`). New tests must be appended at the end of the
 test list, since drivers may refer to existing tests by number.
 
 Outdated tests must not be removed completely, but may be marked as such (e.g. by striking through or replacing the
 entire test with a note (e.g. *Removed*).
 
+## Automated Test Best Practices
+
+### Immutability of Existing Tests
+
+**Do not modify existing tests**, unless they are testing incorrect behavior. Default to creating new tests or test
+files instead of altering existing ones.
+
+Test files can only be deleted once no driver runs them anymore. In the meantime, for cases where a spec change removes
+functionality:
+
+- **Unified Tests:** Use `runOnRequirements` to ensure tests are only executed by drivers supporting the required
+    functionality.
+- **Non-Unified Tests (e.g., SDAM):** Drivers should skip tests that no longer apply to them.
+
+### Test Isolation
+
+When creating a new test, only test functionality directly related to the new spec requirements. Omit irrelevant fields
+in command expectations.
+
+This makes tests more resilient against spec updates and avoids needing to change tests down the line.
+
+### Schema Version Usage
+
+Use the **lowest possible schema version** for each test.
+
+Do NOT default to using the latest unified test format schema version, as the drivers may not all implement it. Use the
+oldest schema version that supports all functionality used in the test, even if it requires creating a new test file
+with a lower schema version.
+
 ## Building Documents
 
 We use [mkdocs](https://www.mkdocs.org/) to render the documentation. To see a live view of the documentation, in a

source/auth/tests/mongodb-oidc.md

@@ -232,6 +232,31 @@ source the `secrets-export.sh` file and use the associated env variables in your
 - Assert there were `SaslStart` commands executed.
 - Close the client.
 
+#### 4.5 Reauthentication Succeeds when a Session is involved
+
+- Create an OIDC configured client.
+- Set a fail point for `find` commands of the form:
+
+```javascript
+{
+  configureFailPoint: "failCommand",
+  mode: {
+    times: 1
+  },
+  data: {
+    failCommands: [
+      "find"
+    ],
+    errorCode: 391 // ReauthenticationRequired
+  }
+}
+```
+
+- Start a new session.
+- In the started session perform a `find` operation that succeeds.
+- Assert that the callback was called 2 times (once during the connection handshake, and again during reauthentication).
+- Close the session and the client.
+
 ## (5) Azure Tests
 
 Drivers MUST only run the Azure tests when testing on an Azure VM. See instructions in

source/change-streams/tests/README.md

@@ -194,23 +194,13 @@ and sharded clusters unless otherwise specified:
 
 11. For a `ChangeStream` under these conditions:
 
-    - Running against a server `>=4.0.7`.
     - The batch is empty or has been iterated to the last document.
 
     Expected result:
 
     - `getResumeToken` must return the `postBatchResumeToken` from the current command response.
 
-12. For a `ChangeStream` under these conditions:
-
-    - Running against a server `<4.0.7`.
-    - The batch is empty or has been iterated to the last document.
-
-    Expected result:
-
-    - `getResumeToken` must return the `_id` of the last document returned if one exists.
-    - `getResumeToken` must return `resumeAfter` from the initial aggregate if the option was specified.
-    - If `resumeAfter` was not specified, the `getResumeToken` result must be empty.
+12. **Removed**
 
 13. For a `ChangeStream` under these conditions:
 

source/client-side-encryption/tests/unified/fle2v2-BypassQueryAnalysis.json

@@ -28,6 +28,16 @@ createEntities:
       id: &encryptedColl encryptedColl
       database: *encryptedDB
       collectionName: &encryptedCollName default
+  - client:
+      id: &client1 client1
+  - database:
+      id: &unencryptedDB unencryptedDB
+      client: *client1
+      databaseName: *encryptedDBName
+  - collection:
+      id: &unencryptedColl unencryptedColl
+      database: *unencryptedDB
+      collectionName: *encryptedCollName
 
 initialData:
   - databaseName: &keyvaultDBName keyvault
@@ -61,6 +71,12 @@ tests:
         arguments:
           filter: { "_id": 1 }
         expectResult: [{"_id": 1, "encryptedIndexed": "123" }]
+      - object: *unencryptedColl
+        name: find
+        arguments:
+          filter: {}
+        expectResult:
+          - {"_id": 1, "encryptedIndexed": { "$$type": "binData" }, "__safeContent__": [{ "$binary" : { "base64" : "31eCYlbQoVboc5zwC8IoyJVSkag9PxREka8dkmbXJeY=", "subType" : "00" } }] }
     expectEvents:
       - client: *client0
         events:
@@ -111,9 +127,4 @@ tests:
                 }
               $db: *keyvaultDBName
               readConcern: { level: "majority" }
-            commandName: find
-    outcome:
-      - collectionName: *encryptedCollName
-        databaseName: *encryptedDBName
-        documents:
-          - {"_id": 1, "encryptedIndexed": { "$$type": "binData" }, "__safeContent__": [{ "$binary" : { "base64" : "31eCYlbQoVboc5zwC8IoyJVSkag9PxREka8dkmbXJeY=", "subType" : "00" } }] }
+            commandName: find