Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6801): set token on connection from cache #4438

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

durran
Copy link
Member

@durran durran commented Feb 28, 2025

Description

When using OIDC authentication when there is more than one connection in the pool, connections that were created after the first connection would have no access token set on them until after the first reauthentication attempt. This was due to the fact that the first connection that was created retrieved the token and put it in the cache, and all following connections weren't setting their access token properly from the cache if it existed.

What is changing?

  • Changes the machine workflow to properly set a token from the cache on the connection if the connection's token is undefined.
  • Adds a unit test.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

HELP-70195

Release Highlight

Fixed an issue in OIDC authentication where 391 reauthentication could fail.

This was due to a bug in setting the properly cached access token on the connection.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran requested a review from a team as a code owner February 28, 2025 17:12
@W-A-James W-A-James self-assigned this Feb 28, 2025
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 28, 2025
@W-A-James W-A-James requested review from W-A-James and removed request for a team February 28, 2025 17:43
@W-A-James W-A-James changed the title fix: set token on connection from cache fix(NODE-6801): set token on connection from cache Feb 28, 2025
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 28, 2025
@nbbeeken nbbeeken requested a review from baileympearson March 3, 2025 16:00
@W-A-James W-A-James merged commit cb13746 into main Mar 3, 2025
28 of 30 checks passed
@W-A-James W-A-James deleted the fix-conn-cache branch March 3, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants