feat(NODE-6451): retry SRV and TXT lookup for DNS timeout errors #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-6451-retry-dns
branch
from
84809c7 to
35f723b
Compare
aditi-khare-mongoDB
added
the
Primary Review
aditi-khare-mongoDB
previously approved these changes
Jan 22, 2025
aditi-khare-mongoDB
added
Team Review
baileympearson
requested changes
Jan 23, 2025
test/integration/initial-dns-seedlist-discovery/dns_seedlist.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/dns_seedlist.test.ts
Outdated
Show resolved
Hide resolved
baileympearson
changed the title
baileympearson
approved these changes
Jan 23, 2025
W-A-James
pushed a commit
that referenced
this pull request
Jan 27, 2025
Co-authored-by: Aditi Khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
Yes API updated
What is the motivation for this change?
In some environments (possibly FAAS?) it has been observed that DNS look ups can fail transiently. The driver can attempt to mitigate these with a retry.
Release Highlight
DNS SRV & TXT look up timeouts are retried
To mitigate the potentially transient DNS timeout error, the driver now catches and retries the DNS lookups upon resolving a
mongodb+srv://style connection string.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript