fix(NODE-4557): randomize servers when there are only 2 eligible servers #3390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
changed the title
baileympearson
force-pushed
the
NODE-4557-operation-count-poc
branch
from
1dd3ade to
36dd672
Compare
baileympearson
force-pushed
the
NODE-4557-operation-count-poc
branch
from
36dd672 to
6596261
Compare
baileympearson
changed the title
baileympearson
changed the title
nbbeeken
added
the
Primary Review
durran
reviewed
Aug 31, 2022
nbbeeken
previously approved these changes
Aug 31, 2022
nbbeeken
added
Team Review
baileympearson
changed the title
durran
previously approved these changes
Aug 31, 2022
jyemin
reviewed
Aug 31, 2022
nbbeeken
approved these changes
Sep 1, 2022
jyemin
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
When we encounter exactly 2 eligible servers in the server selection process, we now shuffle the array of two servers. This prevents a scenario where, when we receive a sequence of operations and each operation completes before the next (or approximately this scenario), we would select the same server for each request.
Is there new documentation needed for these changes?
No.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>