fix(NODE-6259): replace dynamically assigned length property with a static getter (#4173)

sis0k0 · web-flow · commit 320dde04aa15 · 2024-07-11T15:22:50.000-04:00
diff --git a/src/bulk/common.ts b/src/bulk/common.ts
@@ -1178,6 +1178,10 @@ export abstract class BulkOperationBase {
     );
   }
 
+  get length(): number {
+    return this.s.currentIndex;
+  }
+
   get bsonOptions(): BSONSerializeOptions {
     return this.s.bsonOptions;
   }
@@ -1274,13 +1278,6 @@ export abstract class BulkOperationBase {
   }
 }
 
-Object.defineProperty(BulkOperationBase.prototype, 'length', {
-  enumerable: true,
-  get() {
-    return this.s.currentIndex;
-  }
-});
-
 function isInsertBatch(batch: Batch): boolean {
   return batch.batchType === BatchType.INSERT;
 }

Original file line number	Diff line number	Diff line change
`@@ -1178,6 +1178,10 @@ export abstract class BulkOperationBase {`
`1178`	`1178`	`);`
`1179`	`1179`	`}`
`1180`	`1180`
	`1181`	`+ get length(): number {`
	`1182`	`+ return this.s.currentIndex;`
	`1183`	`+ }`
	`1184`	`+`
`1181`	`1185`	`get bsonOptions(): BSONSerializeOptions {`
`1182`	`1186`	`return this.s.bsonOptions;`
`1183`	`1187`	`}`
`@@ -1274,13 +1278,6 @@ export abstract class BulkOperationBase {`
`1274`	`1278`	`}`
`1275`	`1279`	`}`
`1276`	`1280`
`1277`		`-Object.defineProperty(BulkOperationBase.prototype, 'length', {`
`1278`		`- enumerable: true,`
`1279`		`- get() {`
`1280`		`- return this.s.currentIndex;`
`1281`		`- }`
`1282`		`-});`
`1283`		`-`
`1284`	`1281`	`function isInsertBatch(batch: Batch): boolean {`
`1285`	`1282`	`return batch.batchType === BatchType.INSERT;`
`1286`	`1283`	`}`