Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Client.listTools return type to include next cursor #54

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Update Client.listTools return type to include next cursor #54

merged 1 commit into from
Apr 9, 2025

Conversation

mattt
Copy link
Contributor

@mattt mattt commented Apr 4, 2025 •
edited
Loading

Resolves #49

This PR introduces a breaking change to Client.listTools, making it return a tuple of ([Tool], String?), instead of its current [Tool]. This change makes listTools consistent with the other list methods, and allows it to support pagination.

// New usage
let (tools, nextCursor) = try await client.listTools()


// Old usage
let tools = try await client.listTools()

stallent
stallent approved these changes Apr 4, 2025
View reviewed changes
Copy link

@stallent stallent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, good sir.

@mattt mattt merged commit 20d4fe6 into main Apr 9, 2025
1 check passed
@mattt mattt deleted the mattt/change-listtools-return-type branch April 9, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stallent stallent stallent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent return type for Client.listTools method
2 participants
@mattt @stallent