Skip to content

Commit 1550e63

Browse files
moarychanmoarychan
committed
Resolve comments
1 parent cb1dc6a commit 1550e63

File tree

7 files changed

+175
-175
lines changed

7 files changed

+175
-175
lines changed

‎keyvault/spring-cloud-azure-starter-keyvault-jca/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Spring Boot application with Azure Key Vault JCA
22

3-
This repo demonstrates how to use [Java Crypto Architecture (JCA) Provider] for Azure Key Vault in [Spring Boot] application by Spring SSL Bundles. We support using Key Vault SSL Bundles to enable embedded Web Server SSL, RestTemplate SSL, and WebClient SSL. There are three specific scenarios.
3+
This repo demonstrates how to use [Java Crypto Architecture (JCA) Provider] for Azure Key Vault in [Spring Boot] application by Spring Boot [SSL Bundles](https://docs.spring.io/spring-boot/reference/features/ssl.html). We support using Key Vault SSL Bundles to enable embedded Web Server SSL, RestTemplate SSL, and WebClient SSL. There are three specific scenarios.
44

55
[Java Crypto Architecture (JCA) Provider]: https://github.com/Azure/azure-sdk-for-java/tree/main/sdk/keyvault/azure-security-keyvault-jca
66
[Spring Boot]: https://spring.io/projects/spring-boot

‎keyvault/spring-cloud-azure-starter-keyvault-jca/ssl-bundles-rest-template/README.md

+8-8
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ description: This sample demonstrates how to enable RestTemplate SSL via Azure K
1010

1111
# Enable RestTemplate SSL from Azure Key Vault SSL Bundles in Spring Boot Web Application
1212

13-
This sample demonstrates how to enable RestTemplate SSL via Azure KeyVault SSL bundles in Spring Boot web application. [Link to reference doc](https://learn.microsoft.com/azure/developer/java/spring-framework).
13+
This sample demonstrates how to enable RestTemplate SSL via Azure KeyVault SSL bundles in Spring Boot web application.
1414

1515
## What You Will Build
1616

@@ -21,7 +21,7 @@ You will build an application that use `spring-cloud-azure-starter-keyvault-jca`
2121
- [An Azure subscription](https://azure.microsoft.com/free/)
2222
- [Terraform](https://www.terraform.io/)
2323
- [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli)
24-
- [JDK8](https://www.oracle.com/java/technologies/downloads/) or later
24+
- [JDK 17](https://www.oracle.com/java/technologies/downloads/) or later
2525
- Maven
2626
- You can also import the code straight into your IDE:
2727
- [IntelliJ IDEA](https://www.jetbrains.com/idea/download)
@@ -136,12 +136,12 @@ terraform\setup_env.ps1
136136
If you want to run the sample in debug mode, you can save the output value.
137137

138138
```shell
139-
KEY_VAULT_SSL_BUNDLE_CLIENT_ID=
140-
KEY_VAULT_SSL_BUNDLE_CLIENT_SECRET=
141-
KEY_VAULT_SSL_BUNDLE_KEYVAULT_URI_01=
142-
KEY_VAULT_SSL_BUNDLE_KEYVAULT_URI_02=
143-
KEY_VAULT_SSL_BUNDLE_RESOURCE_GROUP_NAME=
144-
KEY_VAULT_SSL_BUNDLE_TENANT_ID=
139+
KEY_VAULT_SSL_BUNDLES_CLIENT_ID=
140+
KEY_VAULT_SSL_BUNDLES_CLIENT_SECRET=
141+
KEY_VAULT_SSL_BUNDLES_KEYVAULT_URI_01=
142+
KEY_VAULT_SSL_BUNDLES_KEYVAULT_URI_02=
143+
KEY_VAULT_SSL_BUNDLES_RESOURCE_GROUP_NAME=
144+
KEY_VAULT_SSL_BUNDLES_TENANT_ID=
145145
```
146146

147147
## Run Locally

‎keyvault/spring-cloud-azure-starter-keyvault-jca/ssl-bundles-rest-template/pom.xml

+50-50
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,56 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3-
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
4-
<modelVersion>4.0.0</modelVersion>
5-
<parent>
6-
<groupId>org.springframework.boot</groupId>
7-
<artifactId>spring-boot-starter-parent</artifactId>
8-
<version>3.4.2</version>
9-
<relativePath/> <!-- lookup parent from repository -->
10-
</parent>
11-
<groupId>com.azure.spring</groupId>
12-
<artifactId>ssl-bundles-rest-template</artifactId>
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
4+
<modelVersion>4.0.0</modelVersion>
5+
<parent>
6+
<groupId>org.springframework.boot</groupId>
7+
<artifactId>spring-boot-starter-parent</artifactId>
8+
<version>3.4.2</version>
9+
<relativePath/> <!-- lookup parent from repository -->
10+
</parent>
11+
<groupId>com.azure.spring</groupId>
12+
<artifactId>ssl-bundles-rest-template</artifactId>
1313
<version>1.0.0</version>
1414
<packaging>jar</packaging>
15-
<name>keyvault-ssl-bundles-rest-template</name>
16-
<description>Spring Cloud Azure Starter Key Vault JCA: Enable RestTemplate SSL in Spring Boot Web application</description>
17-
<properties>
18-
<java.version>17</java.version>
19-
<spring-cloud-azure.version>5.21.0</spring-cloud-azure.version>
20-
</properties>
21-
<dependencies>
22-
<dependency>
23-
<groupId>org.springframework.boot</groupId>
24-
<artifactId>spring-boot-starter-web</artifactId>
25-
</dependency>
26-
<dependency>
27-
<groupId>com.azure.spring</groupId>
28-
<artifactId>spring-cloud-azure-starter-keyvault-jca</artifactId>
29-
</dependency>
30-
<dependency>
31-
<groupId>org.springframework.boot</groupId>
32-
<artifactId>spring-boot-starter-test</artifactId>
33-
<scope>test</scope>
34-
</dependency>
35-
</dependencies>
36-
<dependencyManagement>
37-
<dependencies>
38-
<dependency>
39-
<groupId>com.azure.spring</groupId>
40-
<artifactId>spring-cloud-azure-dependencies</artifactId>
41-
<version>${spring-cloud-azure.version}</version>
42-
<type>pom</type>
43-
<scope>import</scope>
44-
</dependency>
45-
</dependencies>
46-
</dependencyManagement>
15+
<name>keyvault-ssl-bundles-rest-template</name>
16+
<description>Spring Cloud Azure Starter Key Vault JCA: Enable RestTemplate SSL in Spring Boot Web application</description>
17+
<properties>
18+
<java.version>17</java.version>
19+
<spring-cloud-azure.version>5.21.0</spring-cloud-azure.version>
20+
</properties>
21+
<dependencies>
22+
<dependency>
23+
<groupId>org.springframework.boot</groupId>
24+
<artifactId>spring-boot-starter-web</artifactId>
25+
</dependency>
26+
<dependency>
27+
<groupId>com.azure.spring</groupId>
28+
<artifactId>spring-cloud-azure-starter-keyvault-jca</artifactId>
29+
</dependency>
30+
<dependency>
31+
<groupId>org.springframework.boot</groupId>
32+
<artifactId>spring-boot-starter-test</artifactId>
33+
<scope>test</scope>
34+
</dependency>
35+
</dependencies>
36+
<dependencyManagement>
37+
<dependencies>
38+
<dependency>
39+
<groupId>com.azure.spring</groupId>
40+
<artifactId>spring-cloud-azure-dependencies</artifactId>
41+
<version>${spring-cloud-azure.version}</version>
42+
<type>pom</type>
43+
<scope>import</scope>
44+
</dependency>
45+
</dependencies>
46+
</dependencyManagement>
4747

48-
<build>
49-
<plugins>
50-
<plugin>
51-
<groupId>org.springframework.boot</groupId>
52-
<artifactId>spring-boot-maven-plugin</artifactId>
53-
</plugin>
54-
</plugins>
55-
</build>
48+
<build>
49+
<plugins>
50+
<plugin>
51+
<groupId>org.springframework.boot</groupId>
52+
<artifactId>spring-boot-maven-plugin</artifactId>
53+
</plugin>
54+
</plugins>
55+
</build>
5656
</project>

‎keyvault/spring-cloud-azure-starter-keyvault-jca/ssl-bundles-server/README.md

+8-8
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ description: This sample demonstrates how to enable Server and Client SSL via Az
1010

1111
# Enable Server and RestTemplate SSL from Azure Key Vault SSL Bundles in Spring Boot Web Application
1212

13-
This sample demonstrates how to enable Server and RestTemplate SSL via Azure KeyVault SSL bundles in Spring Boot web application. [Link to reference doc](https://learn.microsoft.com/azure/developer/java/spring-framework).
13+
This sample demonstrates how to enable Server and RestTemplate SSL via Azure KeyVault SSL bundles in Spring Boot web application.
1414

1515
## What You Will Build
1616

@@ -21,7 +21,7 @@ You will build an application that use `spring-cloud-azure-starter-keyvault-jca`
2121
- [An Azure subscription](https://azure.microsoft.com/free/)
2222
- [Terraform](https://www.terraform.io/)
2323
- [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli)
24-
- [JDK8](https://www.oracle.com/java/technologies/downloads/) or later
24+
- [JDK 17](https://www.oracle.com/java/technologies/downloads/) or later
2525
- Maven
2626
- You can also import the code straight into your IDE:
2727
- [IntelliJ IDEA](https://www.jetbrains.com/idea/download)
@@ -136,12 +136,12 @@ terraform\setup_env.ps1
136136
If you want to run the sample in debug mode, you can save the output value.
137137

138138
```shell
139-
KEY_VAULT_SSL_BUNDLE_CLIENT_ID=
140-
KEY_VAULT_SSL_BUNDLE_CLIENT_SECRET=
141-
KEY_VAULT_SSL_BUNDLE_KEYVAULT_URI_01=
142-
KEY_VAULT_SSL_BUNDLE_KEYVAULT_URI_02=
143-
KEY_VAULT_SSL_BUNDLE_RESOURCE_GROUP_NAME=
144-
KEY_VAULT_SSL_BUNDLE_TENANT_ID=
139+
KEY_VAULT_SSL_BUNDLES_CLIENT_ID=
140+
KEY_VAULT_SSL_BUNDLES_CLIENT_SECRET=
141+
KEY_VAULT_SSL_BUNDLES_KEYVAULT_URI_01=
142+
KEY_VAULT_SSL_BUNDLES_KEYVAULT_URI_02=
143+
KEY_VAULT_SSL_BUNDLES_RESOURCE_GROUP_NAME=
144+
KEY_VAULT_SSL_BUNDLES_TENANT_ID=
145145
```
146146

147147
## Run Locally

‎keyvault/spring-cloud-azure-starter-keyvault-jca/ssl-bundles-server/pom.xml

+50-50
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,56 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3-
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
4-
<modelVersion>4.0.0</modelVersion>
5-
<parent>
6-
<groupId>org.springframework.boot</groupId>
7-
<artifactId>spring-boot-starter-parent</artifactId>
8-
<version>3.4.2</version>
9-
<relativePath/> <!-- lookup parent from repository -->
10-
</parent>
11-
<groupId>com.azure.spring</groupId>
12-
<artifactId>ssl-bundles-server</artifactId>
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
4+
<modelVersion>4.0.0</modelVersion>
5+
<parent>
6+
<groupId>org.springframework.boot</groupId>
7+
<artifactId>spring-boot-starter-parent</artifactId>
8+
<version>3.4.2</version>
9+
<relativePath/> <!-- lookup parent from repository -->
10+
</parent>
11+
<groupId>com.azure.spring</groupId>
12+
<artifactId>ssl-bundles-server</artifactId>
1313
<version>1.0.0</version>
1414
<packaging>jar</packaging>
15-
<name>ssl-bundles-server</name>
16-
<description>Spring Cloud Azure Starter Key Vault JCA: Enable Server SSL and RestTemplate SSL in Spring Boot Web application</description>
17-
<properties>
18-
<java.version>17</java.version>
19-
<spring-cloud-azure.version>5.21.0</spring-cloud-azure.version>
20-
</properties>
21-
<dependencies>
22-
<dependency>
23-
<groupId>org.springframework.boot</groupId>
24-
<artifactId>spring-boot-starter-web</artifactId>
25-
</dependency>
26-
<dependency>
27-
<groupId>com.azure.spring</groupId>
28-
<artifactId>spring-cloud-azure-starter-keyvault-jca</artifactId>
29-
</dependency>
30-
<dependency>
31-
<groupId>org.springframework.boot</groupId>
32-
<artifactId>spring-boot-starter-test</artifactId>
33-
<scope>test</scope>
34-
</dependency>
35-
</dependencies>
36-
<dependencyManagement>
37-
<dependencies>
38-
<dependency>
39-
<groupId>com.azure.spring</groupId>
40-
<artifactId>spring-cloud-azure-dependencies</artifactId>
41-
<version>${spring-cloud-azure.version}</version>
42-
<type>pom</type>
43-
<scope>import</scope>
44-
</dependency>
45-
</dependencies>
46-
</dependencyManagement>
15+
<name>ssl-bundles-server</name>
16+
<description>Spring Cloud Azure Starter Key Vault JCA: Enable Server SSL and RestTemplate SSL in Spring Boot Web application</description>
17+
<properties>
18+
<java.version>17</java.version>
19+
<spring-cloud-azure.version>5.21.0</spring-cloud-azure.version>
20+
</properties>
21+
<dependencies>
22+
<dependency>
23+
<groupId>org.springframework.boot</groupId>
24+
<artifactId>spring-boot-starter-web</artifactId>
25+
</dependency>
26+
<dependency>
27+
<groupId>com.azure.spring</groupId>
28+
<artifactId>spring-cloud-azure-starter-keyvault-jca</artifactId>
29+
</dependency>
30+
<dependency>
31+
<groupId>org.springframework.boot</groupId>
32+
<artifactId>spring-boot-starter-test</artifactId>
33+
<scope>test</scope>
34+
</dependency>
35+
</dependencies>
36+
<dependencyManagement>
37+
<dependencies>
38+
<dependency>
39+
<groupId>com.azure.spring</groupId>
40+
<artifactId>spring-cloud-azure-dependencies</artifactId>
41+
<version>${spring-cloud-azure.version}</version>
42+
<type>pom</type>
43+
<scope>import</scope>
44+
</dependency>
45+
</dependencies>
46+
</dependencyManagement>
4747

48-
<build>
49-
<plugins>
50-
<plugin>
51-
<groupId>org.springframework.boot</groupId>
52-
<artifactId>spring-boot-maven-plugin</artifactId>
53-
</plugin>
54-
</plugins>
55-
</build>
48+
<build>
49+
<plugins>
50+
<plugin>
51+
<groupId>org.springframework.boot</groupId>
52+
<artifactId>spring-boot-maven-plugin</artifactId>
53+
</plugin>
54+
</plugins>
55+
</build>
5656
</project>

‎keyvault/spring-cloud-azure-starter-keyvault-jca/ssl-bundles-web-client/README.md

+8-8
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ description: This sample demonstrates how to enable Client SSL via Azure KeyVaul
1010

1111
# Enable WebClient SSL from Azure Key Vault SSL Bundles in Spring Boot Reactive Web Application
1212

13-
This sample demonstrates how to enable WebClient SSL via Azure KeyVault SSL bundles in Spring Boot Reactive Web application. [Link to reference doc](https://learn.microsoft.com/azure/developer/java/spring-framework).
13+
This sample demonstrates how to enable WebClient SSL via Azure KeyVault SSL bundles in Spring Boot Reactive Web application.
1414

1515
## What You Will Build
1616

@@ -21,7 +21,7 @@ You will build an application that use `spring-cloud-azure-starter-keyvault-jca`
2121
- [An Azure subscription](https://azure.microsoft.com/free/)
2222
- [Terraform](https://www.terraform.io/)
2323
- [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli)
24-
- [JDK8](https://www.oracle.com/java/technologies/downloads/) or later
24+
- [JDK 17](https://www.oracle.com/java/technologies/downloads/) or later
2525
- Maven
2626
- You can also import the code straight into your IDE:
2727
- [IntelliJ IDEA](https://www.jetbrains.com/idea/download)
@@ -136,12 +136,12 @@ terraform\setup_env.ps1
136136
If you want to run the sample in debug mode, you can save the output value.
137137

138138
```shell
139-
KEY_VAULT_SSL_BUNDLE_CLIENT_ID=
140-
KEY_VAULT_SSL_BUNDLE_CLIENT_SECRET=
141-
KEY_VAULT_SSL_BUNDLE_KEYVAULT_URI_01=
142-
KEY_VAULT_SSL_BUNDLE_KEYVAULT_URI_02=
143-
KEY_VAULT_SSL_BUNDLE_RESOURCE_GROUP_NAME=
144-
KEY_VAULT_SSL_BUNDLE_TENANT_ID=
139+
KEY_VAULT_SSL_BUNDLES_CLIENT_ID=
140+
KEY_VAULT_SSL_BUNDLES_CLIENT_SECRET=
141+
KEY_VAULT_SSL_BUNDLES_KEYVAULT_URI_01=
142+
KEY_VAULT_SSL_BUNDLES_KEYVAULT_URI_02=
143+
KEY_VAULT_SSL_BUNDLES_RESOURCE_GROUP_NAME=
144+
KEY_VAULT_SSL_BUNDLES_TENANT_ID=
145145
```
146146

147147
## Run Locally

0 commit comments

Comments
 (0)