add model tests + setup cfg

Author: Asad Ali

run_edx_integration_tests.sh

@@ -78,7 +78,7 @@ run_plugin_tests() {
     fi
 
     # Run the pytest command with CMS settings (for ol_openedx_chat)
-    if [[ "$plugin_dir" == *"ol_openedx_chat"* ]]; then
+    if [[ "$plugin_dir" == *"ol_openedx_chat"* || "$plugin_dir" == *"ol_openedx_course_sync"* ]]; then
         pytest . --cov . --ds=cms.envs.test
 
         PYTEST_SUCCESS=$?

src/ol_openedx_course_sync/BUILD

@@ -2,8 +2,6 @@ python_sources(
     name="ol_openedx_course_sync_source",
     dependencies=[
         "src/ol_openedx_course_sync/migrations:ol_openedx_course_sync_migrations",
-        "//:external_dependencies#edx-opaque-keys",
-        "//:external_dependencies#celery",
     ],
 )
 

src/ol_openedx_course_sync/setup.cfg

@@ -0,0 +1,41 @@
+[isort]
+include_trailing_comma = True
+indent = '    '
+line_length = 120
+multi_line_output = 3
+skip=
+    migrations
+
+[wheel]
+universal = 1
+
+[tool:pytest]
+pep8maxlinelength = 119
+DJANGO_SETTINGS_MODULE = lms.envs.test
+addopts = --nomigrations --reuse-db --durations=20
+# Enable default handling for all warnings, including those that are ignored by default;
+# but hide rate-limit warnings (because we deliberately don't throttle test user logins)
+# and field_data deprecation warnings (because fixing them requires a major low-priority refactoring)
+filterwarnings =
+    default
+    ignore::xblock.exceptions.FieldDataDeprecationWarning
+    ignore::pytest.PytestConfigWarning
+    ignore:No request passed to the backend, unable to rate-limit:UserWarning
+    ignore:Flags not at the start of the expression:DeprecationWarning
+    ignore:Using or importing the ABCs from 'collections' instead of from 'collections.abc':DeprecationWarning
+    ignore:invalid escape sequence:DeprecationWarning
+    ignore:`formatargspec` is deprecated since Python 3.5:DeprecationWarning
+    ignore:the imp module is deprecated in favour of importlib:DeprecationWarning
+    ignore:"is" with a literal:SyntaxWarning
+    ignore:defusedxml.lxml is no longer supported:DeprecationWarning
+    ignore: `np.int` is a deprecated alias for the builtin `int`.:DeprecationWarning
+    ignore: `np.float` is a deprecated alias for the builtin `float`.:DeprecationWarning
+    ignore: `np.complex` is a deprecated alias for the builtin `complex`.:DeprecationWarning
+    ignore: 'etree' is deprecated. Use 'xml.etree.ElementTree' instead.:DeprecationWarning
+    ignore: defusedxml.cElementTree is deprecated, import from defusedxml.ElementTree instead.:DeprecationWarning
+
+
+junit_family = xunit2
+norecursedirs = .* *.egg build conf dist node_modules test_root cms/envs lms/envs
+python_classes =
+python_files = tests.py test_*.py tests_*.py *_tests.py __init__.py

src/ol_openedx_course_sync/tests/test_models.py

@@ -1,21 +1,73 @@
-"""
-Tests for models
-"""
-
+import pytest
+from django.core.exceptions import ValidationError
 from ol_openedx_course_sync.models import CourseSyncMap
 from openedx.core.djangolib.testing.utils import skip_unless_cms
 
 
 @skip_unless_cms
-def test_course_sync_map_clean():
+@pytest.mark.django_db()
+@pytest.mark.parametrize(
+    ("existing", "new", "expected_error_field"),
+    [
+        # Case 1: source_course is already a target_course elsewhere
+        (
+            {
+                "source_course": "course-v1:edX+DemoX+2025",
+                "target_courses": "course-v1:edX+DemoX+2026",
+            },
+            {
+                "source_course": "course-v1:edX+DemoX+2026",
+                "target_courses": "course-v1:edX+DemoX+2027",
+            },
+            "source_course",
+        ),
+        # Case 2: target_course is already a source_course elsewhere
+        (
+            {
+                "source_course": "course-v1:edX+DemoX+2028",
+                "target_courses": "course-v1:edX+DemoX+2029",
+            },
+            {
+                "source_course": "course-v1:edX+DemoX+2030",
+                "target_courses": "course-v1:edX+DemoX+2028",
+            },
+            "target_courses",
+        ),
+        # Case 3: target_course is already used as target_course in another mapping
+        (
+            {
+                "source_course": "course-v1:edX+DemoX+2031",
+                "target_courses": "course-v1:edX+DemoX+2032",
+            },
+            {
+                "source_course": "course-v1:edX+DemoX+2033",
+                "target_courses": "course-v1:edX+DemoX+2032",
+            },
+            "target_courses",
+        ),
+    ],
+)
+def test_course_sync_map_clean_conflicts(existing, new, expected_error_field):
     """
-    Test the clean method of CourseSyncMap model.
+    Parametrized test to validate CourseSyncMap.clean() conflicts:
+    - A source course cannot be used as a target.
+    - A target course cannot be used as a source.
+    - Target courses cannot be duplicated across mappings.
     """
-    course_sync_map = CourseSyncMap(
-        source_course="course-v1:UAI+UAI102+R5",
-        target_courses=["target_course_1", "target_course_2"],
-    )
+    CourseSyncMap.objects.create(**existing)
+    obj = CourseSyncMap(**new)
+
+    with pytest.raises(ValidationError) as context:
+        obj.full_clean()
+    assert expected_error_field in context.value.error_dict
 
-    course_sync_map.clean()
 
-    assert True
+@skip_unless_cms
+@pytest.mark.django_db()
+def test_valid_course_sync_map():
+    """Valid CourseSyncMap instance should pass validation."""
+    obj = CourseSyncMap(
+        source_course="course-v1:edX+DemoX+2040",
+        target_courses="course-v1:edX+DemoX+2041,course-v1:edX+DemoX+2042",
+    )
+    obj.full_clean()  # Should not raise