Skip to content

Fix type definitions for basically all React components #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gsidebo opened this issue Mar 20, 2020 · 0 comments
Open

Fix type definitions for basically all React components #836

gsidebo opened this issue Mar 20, 2020 · 0 comments

Comments

@gsidebo
Copy link
Contributor

gsidebo commented Mar 20, 2020

Most/all of our React components follow a definition anti-pattern that we repeated in several of our projects before someone finally noticed it. It looks something like this: export class MyPage extends React.Component<*, void>. That React.Component<*, void> basically ignores any type definitions and tells the type checker to accept props of any sort. This may be time-consuming as I noticed several components with clearly incorrect type definitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant