Skip to content

Commit e6eb60d

Browse files
authored
remove already removed method (#1155)
1 parent 5144d0d commit e6eb60d

File tree

4 files changed

+2
-63
lines changed

4 files changed

+2
-63
lines changed

docs/API.md

+1-3
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ var s3Client = new Minio.Client({
4242
| [`getBucketTagging`](#getBucketTagging) | [`removeIncompleteUpload`](#removeIncompleteUpload) | | | | |
4343
| [`setBucketTagging`](#setBucketTagging) | [`putObjectRetention`](#putObjectRetention) | | | | |
4444
| [`removeBucketTagging`](#removeBucketTagging) | [`getObjectRetention`](#getObjectRetention) | | | | |
45-
| [`setBucketLifecycle`](#setBucketLifecycle) | [`putObjectTagging`](#putObjectTagging) | | | | |
45+
| [`setBucketLifecycle`](#setBucketLifecycle) | [`setObjectTagging`](#setObjectTagging) | | | | |
4646
| [`getBucketLifecycle`](#getBucketLifecycle) | [`removeObjectTagging`](#removeObjectTagging) | | | | |
4747
| [`removeBucketLifecycle`](#removeBucketLifecycle) | [`getObjectTagging`](#getObjectTagging) | | | | |
4848
| [`setObjectLockConfig`](#setObjectLockConfig) | [`getObjectLegalHold`](#getObjectLegalHold) | | | | |
@@ -1487,8 +1487,6 @@ minioClient.getObjectRetention('bucketname', 'bucketname', { versionId: "my-vers
14871487
})
14881488
```
14891489

1490-
<a name="putObjectTagging"></a>
1491-
### putObjectTagging(bucketName, objectName, tags[, putOpts, callback])
14921490
<a name="setObjectTagging"></a>
14931491
### setObjectTagging(bucketName, objectName, tags[, putOpts, callback])
14941492

src/minio.d.ts

-25
Original file line numberDiff line numberDiff line change
@@ -446,31 +446,6 @@ export class Client {
446446
): void
447447
getObjectRetention(bucketName: string, objectName: string, options: VersionIdentificator): Promise<Retention>
448448

449-
// It seems, putObjectTagging is deprecated in favor or setObjectTagging - there is no such a method in the library source code
450-
/**
451-
* @deprecated Use setObjectTagging instead.
452-
*/
453-
putObjectTagging(bucketName: string, objectName: string, tags: TagList, callback: NoResultCallback): void
454-
/**
455-
* @deprecated Use setObjectTagging instead.
456-
*/
457-
putObjectTagging(
458-
bucketName: string,
459-
objectName: string,
460-
tags: TagList,
461-
putOptions: VersionIdentificator,
462-
callback: NoResultCallback,
463-
): void
464-
/**
465-
* @deprecated Use setObjectTagging instead.
466-
*/
467-
putObjectTagging(
468-
bucketName: string,
469-
objectName: string,
470-
tags: TagList,
471-
putOptions?: VersionIdentificator,
472-
): Promise<void>
473-
474449
setObjectTagging(bucketName: string, objectName: string, tags: TagList, callback: NoResultCallback): void
475450
setObjectTagging(
476451
bucketName: string,

tests/functional/functional-tests.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2481,7 +2481,7 @@ describe('functional tests', function () {
24812481
},
24822482
)
24832483

2484-
step(`putObjectTagging object_bucketName:${tagsBucketName}, objectName:${tagObjName},`, (done) => {
2484+
step(`setObjectTagging object_bucketName:${tagsBucketName}, objectName:${tagObjName},`, (done) => {
24852485
client.setObjectTagging(tagsBucketName, tagObjName, { 'test-tag-key-obj': 'test-tag-value-obj' }, (err) => {
24862486
if (err && err.code === 'NotImplemented') {
24872487
return done()

tests/unit/test.js

-34
Original file line numberDiff line numberDiff line change
@@ -958,40 +958,6 @@ describe('Client', function () {
958958
}
959959
})
960960
})
961-
describe('Put Object Tags', () => {
962-
it('should fail on null object', (done) => {
963-
try {
964-
client.putObjectTagging('my-bucket-name', null, {}, function () {})
965-
} catch (e) {
966-
done()
967-
}
968-
})
969-
it('should fail on empty object', (done) => {
970-
try {
971-
client.putObjectTagging('my-bucket-name', null, {}, function () {})
972-
} catch (e) {
973-
done()
974-
}
975-
})
976-
it('should fail on non object tags', (done) => {
977-
try {
978-
client.putObjectTagging('my-bucket-name', null, 'non-obj-tag', function () {})
979-
} catch (e) {
980-
done()
981-
}
982-
})
983-
it('should fail if tags are more than 50 on an object', (done) => {
984-
const _50_plus_key_tags = {}
985-
for (let i = 0; i < 51; i += 1) {
986-
_50_plus_key_tags[i] = i
987-
}
988-
try {
989-
client.putObjectTagging('my-bucket-name', null, _50_plus_key_tags, function () {})
990-
} catch (e) {
991-
done()
992-
}
993-
})
994-
})
995961
describe('Get Object Tags', () => {
996962
it('should fail on invalid bucket', (done) => {
997963
try {

0 commit comments

Comments
 (0)