Skip to content

Bump CMake Minimum to 3.5 #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HurricanePootis opened this issue Mar 30, 2025 · 1 comment
Open

Bump CMake Minimum to 3.5 #1106

HurricanePootis opened this issue Mar 30, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@HurricanePootis
Copy link

Problem

CMake 4.0 is out, and now the minimum required compatibility is 3.5. This should be no problem if y'alls packages are built with the latest Ubuntu with github workflows

Whenever configuring mcpelauncher-manifest with cmake 4.0.0, I get the following error:

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

After setting -DCMAKE_POLICY_VERSION_MINIMUM=3.5, I get this new error

CMake Error at mcpelauncher-core/CMakeLists.txt:32 (target_link_libraries):
  The keyword signature for target_link_libraries has already been used with
  the target "mcpelauncher-core".  All uses of target_link_libraries with a
  target must be either all-keyword or all-plain.

  The uses of the keyword signature are here:

   * mcpelauncher-core/CMakeLists.txt:11 (target_link_libraries)
@ChristopherHX
Copy link
Member

I considered to apply this exclusively to the qt6 branch, now the integration test CI needs to decide if this needs a revert or not.

packages are built with the latest Ubuntu with github workflows

Not feasible, ubuntu/fedora are not archlinux and therefore releases have much longer usage time ranges.

It is possible that all cmake versions are higher than 3.5 due to sideloading much more recent cmake for building, but this is complicated to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants