You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged.
35
+
See [Linking a pull request to an issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) and our [Pull Request Guidelines](../docs/developer/pull-request.md) for more information.
Copy file name to clipboardExpand all lines: docs/developer/pull-request.md
+3-2
Original file line number
Diff line number
Diff line change
@@ -8,8 +8,9 @@
8
8
in the curated [release notes](../CHANGELOG.md), add a brief note that summarizes the change in the `release-note` block
9
9
in the PR description.
10
10
- Fill in [our pull request template](/.github/PULL_REQUEST_TEMPLATE.md).
11
-
- Make sure to include the issue number in the PR description to automatically close the issue when the PR mergers.
12
-
See [Closing Issues via Pull Requests](https://github.blog/2013-05-14-closing-issues-via-pull-requests/) for details.
11
+
- Make sure to create an issue and include the issue number in the PR description to automatically close the issue when the PR is merged.
12
+
See [Linking a pull request to an issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) for details.
13
+
An issue might not be required for PRs addressing typos, broken links, etc.
13
14
- For significant changes, break your changes into a logical series of smaller commits. By approaching the changes
14
15
incrementally, it becomes easier to comprehend and review the code.
15
16
- Use your best judgement when resolving comments. Simple, unambiguous comments should be resolved by the submitter,
0 commit comments