feat!(lsp): don't explicitly disable auto trigger for filetypes not in enabled_auto_trigger_ft

Previously, auto-triggering was explicitly disabled for filetypes not
enabled in `config.lsp.enabled_auto_trigger_ft`. This was done to avoid
conflicts with users who enable auto-triggering for all LSP servers that
support completion via the `LspAttach` event. However, this approach
introduced unnecessary complexity.

Now, Minuet no longer explicitly disables auto-triggering on attach.
Instead, it is recommended on the user side to configure auto-triggering
correctly, either through `config.lsp.enabled_auto_trigger_ft` or by
checking the server name in their `LspAttach` handler.

Author: milanglacier

README.md

@@ -256,9 +256,32 @@ Therefore, consider the following options:
 Users might call `vim.lsp.completion.enable {autotrigger = true}` during the
 `LspAttach` event when the client supports completion. However, this is not the
 desired behavior for Minuet. As an LLM completion source, Minuet can face
-significant rate limits during automatic triggering. Consequently, Minuet
-disables auto trigger by default unless the user enables it in
-`config.lsp.enabled_auto_trigger_ft`.
+significant rate limits during automatic triggering.
+
+Therefore, it's recommended to enable Minuet for automatic triggering using the
+`config.lsp.enabled_auto_trigger_ft` setting.
+
+For users who uses `LspAttach` event, it is recommeded to verify that the
+server is not the Minuet server before enabling autotrigger. An example
+configuration is shown below:
+
+```lua
+vim.api.nvim_create_autocmd('LspAttach', {
+    callback = function(args)
+        local client_id = args.data.client_id
+        local bufnr = args.buf
+        local client = vim.lsp.get_client_by_id(client_id)
+        if not client then
+            return
+        end
+
+        if client.server_capabilities.completionProvider and client.name ~= 'minuet' then
+            vim.lsp.completion.enable(true, client_id, bufnr, { autotrigger = true })
+        end
+    end,
+    desc = 'Enable built-in auto completion',
+})
+```
 
 </details>
 

lua/minuet/lsp.lua

@@ -232,22 +232,6 @@ function M.start_server(args)
             then
                 vim.lsp.completion.enable(true, client.id, bufnr, { autotrigger = true })
                 utils.notify('Minuet LSP is enabled for auto triggering', 'verbose', vim.log.levels.INFO)
-            else
-                -- NOTE: Auto-triggering is explicitly disabled for
-                -- filetypes that are not enabled auto triggering. This is
-                -- because some users uses the `LspAttach` event to
-                -- determine if a LSP supports completion, then enabling
-                -- auto-triggering if it does.
-                --
-                -- Minuet, as a LLM completion source, can be subject to
-                -- substantial rate limits during auto-triggering.
-                -- Therefore, completion is disabled by default unless
-                -- explicitly enabled by the user.
-                vim.defer_fn(function()
-                    vim.lsp.completion.enable(false, client.id, bufnr)
-                    vim.lsp.completion.enable(true, client.id, bufnr, { autotrigger = false })
-                    utils.notify('Minuet LSP is disabled for auto triggering', 'verbose', vim.log.levels.INFO)
-                end, 300)
             end
         end,
     }
@@ -334,7 +318,6 @@ M.actions.enable_auto_trigger = function()
     end
 
     for _, client in ipairs(lsps) do
-        vim.lsp.completion.enable(false, client.id, bufnr)
         vim.lsp.completion.enable(true, client.id, bufnr, { autotrigger = true })
     end
 
@@ -352,7 +335,6 @@ M.actions.disable_auto_trigger = function()
 
     for _, client in ipairs(lsps) do
         vim.lsp.completion.enable(false, client.id, bufnr)
-        vim.lsp.completion.enable(true, client.id, bufnr, { autotrigger = false })
         utils.notify('Minuet LSP is disabled for auto triggering', 'verbose', vim.log.levels.INFO)
     end
 end