dereg acl-rule counters during acl-table del (sonic-net#2574)

vivekrnv · web-flow · commit 6185324fe7ae · 2022-12-16T14:12:21.000-08:00
*Deleting ACL Tables deletes all the associated Rules but it doesn't delete the associated counters.
diff --git a/orchagent/aclorch.cpp b/orchagent/aclorch.cpp
@@ -2588,6 +2588,12 @@ bool AclTable::clear()
     for (auto& rulepair: rules)
     {
         auto& rule = *rulepair.second;
+
+        if (rule.hasCounter())
+        {
+            m_pAclOrch->deregisterFlexCounter(rule);
+        }
+
         bool suc = rule.remove();
         if (!suc)
         {

Original file line number	Diff line number	Diff line change
`@@ -2588,6 +2588,12 @@ bool AclTable::clear()`
`2588`	`2588`	`for (auto& rulepair: rules)`
`2589`	`2589`	`{`
`2590`	`2590`	`auto& rule = *rulepair.second;`
	`2591`	`+`
	`2592`	`+ if (rule.hasCounter())`
	`2593`	`+ {`
	`2594`	`+ m_pAclOrch->deregisterFlexCounter(rule);`
	`2595`	`+ }`
	`2596`	`+`
`2591`	`2597`	`bool suc = rule.remove();`
`2592`	`2598`	`if (!suc)`
`2593`	`2599`	`{`