Prevent insertion of font links in head element #636
Conversation
|
I have three requests:
Is this ok for you? Thanks for the PR! |
…(ENV['ember-paper'].insertFontLinks)
Let me know if I need to change anything else! |
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ Version 1.0 introduces many API changes relative to previous releases. In additi | |||
|
|
|||
| Contributions and pull requests are always welcome. Contributors may often be found on the [#e-paper channel on slack](https://embercommunity.slack.com/messages/e-paper/). Building the dummy application by installing `ember-paper` as if it were an application will provide you an up-to-date interactive demo, templates, and code samples. | |||
|
|
|||
| - Consuming apps can now specify `ENV['ember-paper'].insertFontLinks` to prevent the insertion of fonts.googleapi links in the head tag | |||
There was a problem hiding this comment.
The entry should be on a ### master version below.
| contentFor: function(type, config) { | ||
| if (type === 'head') { | ||
| return '<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500,700,400italic">' + | ||
| '<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">'; | ||
| if (config['ember-paper'].insertFontLinks) { |
There was a problem hiding this comment.
You still need to test if type === 'head', right?
|
The nested I'm not sure I understand the changelog structure. Should the entry be placed like this? In the |
|
Can we add this option to the documentation as well? Perhaps in the introduction section? |
|
@anthonycollini done. Will appear when the demo app is deployed again. |
|
Thanks , thats very good! |
Added check on ENV.useFontsFromAssets to prevent the insertion of links to fonts.googleapi.com in the contentFor hook