Skip to content

Commit 848d510

Browse files
committed
Storage/High throughput append blob (Azure#4586)
High Throughput Append Blob Change HandleItem.accessRights to AccessRights
1 parent cec7e71 commit 848d510

File tree

10 files changed

+95
-80
lines changed

10 files changed

+95
-80
lines changed

sdk/storage/assets.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"AssetsRepo": "Azure/azure-sdk-assets",
33
"AssetsRepoPrefixPath": "cpp",
44
"TagPrefix": "cpp/storage",
5-
"Tag": "cpp/storage_497b3668b6"
5+
"Tag": "cpp/storage_8f2bd0dbe5"
66
}

sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/rest_client.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ namespace Azure { namespace Storage { namespace Blobs {
3131
/**
3232
* The version used for the operations to Azure storage services.
3333
*/
34-
constexpr static const char* ApiVersion = "2021-12-02";
34+
constexpr static const char* ApiVersion = "2022-11-02";
3535
} // namespace _detail
3636
namespace Models {
3737
/**

sdk/storage/azure-storage-blobs/src/rest_client.cpp

Lines changed: 70 additions & 70 deletions
Large diffs are not rendered by default.

sdk/storage/azure-storage-blobs/swagger/README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,13 @@ directive:
102102
"name": "ApiVersion",
103103
"modelAsString": false
104104
},
105-
"enum": ["2021-12-02"],
105+
"enum": ["2022-11-02"],
106106
"description": "The version used for the operations to Azure storage services."
107107
};
108+
- from: swagger-document
109+
where: $.parameters
110+
transform: >
111+
$.ApiVersionParameter.enum[0] = "2022-11-02";
108112
```
109113
110114
### Rename Operations

sdk/storage/azure-storage-blobs/test/ut/append_blob_client_test.cpp

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,4 +338,15 @@ namespace Azure { namespace Storage { namespace Test {
338338
appendBlobClient2.AppendBlockFromUri(appendBlobClient.GetUrl() + GetSas(), options2));
339339
}
340340

341+
TEST_F(AppendBlobClientTest, DISABLED_LIVEONLY_HighThroughputAppendBlob)
342+
{
343+
auto appendBlobClient = m_blobContainerClient->GetAppendBlobClient(RandomString());
344+
appendBlobClient.Create();
345+
auto blockContent = RandomBuffer(static_cast<size_t>(5_MB));
346+
auto blockStream = Azure::Core::IO::MemoryBodyStream(blockContent.data(), blockContent.size());
347+
appendBlobClient.AppendBlock(blockStream);
348+
349+
EXPECT_EQ(ReadBodyStream(appendBlobClient.Download().Value.BodyStream), blockContent);
350+
}
351+
341352
}}} // namespace Azure::Storage::Test

sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_responses.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
291291
/**
292292
* Access rights of the handle.
293293
*/
294-
Azure::Nullable<ShareFileHandleAccessRights> accessRights;
294+
Azure::Nullable<ShareFileHandleAccessRights> AccessRights;
295295
};
296296
} // namespace Models
297297

sdk/storage/azure-storage-files-shares/src/share_directory_client.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -609,7 +609,7 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
609609
accessRights |= Models::ShareFileHandleAccessRights::Delete;
610610
}
611611
}
612-
directoryHandle.accessRights = std::move(accessRights);
612+
directoryHandle.AccessRights = std::move(accessRights);
613613
}
614614

615615
pagedResponse.DirectoryHandles.push_back(std::move(directoryHandle));

sdk/storage/azure-storage-files-shares/src/share_file_client.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -715,7 +715,7 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
715715
accessRights |= Models::ShareFileHandleAccessRights::Delete;
716716
}
717717
}
718-
fileHandle.accessRights = std::move(accessRights);
718+
fileHandle.AccessRights = std::move(accessRights);
719719
}
720720

721721
pagedResponse.FileHandles.push_back(std::move(fileHandle));

sdk/storage/azure-storage-files-shares/test/ut/share_directory_client_test.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1090,7 +1090,7 @@ namespace Azure { namespace Storage { namespace Test {
10901090
| Files::Shares::Models::ShareFileHandleAccessRights::Write
10911091
| Files::Shares::Models::ShareFileHandleAccessRights::Delete;
10921092
EXPECT_EQ(directoryHandles.size(), 1L);
1093-
EXPECT_TRUE(directoryHandles[0].accessRights.HasValue());
1094-
EXPECT_EQ(allAccessRights, directoryHandles[0].accessRights.Value());
1093+
EXPECT_TRUE(directoryHandles[0].AccessRights.HasValue());
1094+
EXPECT_EQ(allAccessRights, directoryHandles[0].AccessRights.Value());
10951095
}
10961096
}}} // namespace Azure::Storage::Test

sdk/storage/azure-storage-files-shares/test/ut/share_file_client_test.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1429,7 +1429,7 @@ namespace Azure { namespace Storage { namespace Test {
14291429
| Files::Shares::Models::ShareFileHandleAccessRights::Write
14301430
| Files::Shares::Models::ShareFileHandleAccessRights::Delete;
14311431
EXPECT_EQ(fileHandles.size(), 1L);
1432-
EXPECT_TRUE(fileHandles[0].accessRights.HasValue());
1433-
EXPECT_EQ(allAccessRights, fileHandles[0].accessRights.Value());
1432+
EXPECT_TRUE(fileHandles[0].AccessRights.HasValue());
1433+
EXPECT_EQ(allAccessRights, fileHandles[0].AccessRights.Value());
14341434
}
14351435
}}} // namespace Azure::Storage::Test

0 commit comments

Comments
 (0)