Skip to content

Commit b89733d

Browse files
committed
- fixes an issue where request and builders would generate duplicate methods
1 parent 03b2f74 commit b89733d

File tree

2 files changed

+32
-5
lines changed

2 files changed

+32
-5
lines changed

Templates/Java/requests_extensions/BaseMethodCollectionRequest.java.tt

Lines changed: 30 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,35 @@
66
<#=writer.WriteHeader()#>
77
<#=CreatePackageDef(host)#>
88

9+
import com.microsoft.graph.requests.extensions.<#=ITypeCollectionRequestBuilder(c)#>;
10+
import com.microsoft.graph.requests.extensions.<#=TypeCollectionPage(c)#>;
11+
import com.microsoft.graph.requests.extensions.<#=TypeCollectionResponse(c)#>;
12+
<# if (c.AsOdcmMethod().IsAction() && c.AsOdcmMethod().Parameters.Any()) { #>
13+
import com.microsoft.graph.models.extensions.<#=TypeBody(c)#>;
14+
<# } #>
15+
<# if (ShouldIncludeCollectionTypeReference(c)) { #>
16+
import com.microsoft.graph.models.<#=OdcmMethodReturnNamespaceSection(c as OdcmMethod)#>.<#=OdcmMethodReturnType(c as OdcmMethod)#>;
17+
<# } #>
18+
<# foreach (var method in c.AsOdcmMethod().WithOverloads()) {
19+
var parameterList = MethodParametersImports(method);
20+
if (parameterList != "") {
21+
#>
22+
<#=parameterList#>
23+
<#
24+
}
25+
}
26+
#>
27+
import com.microsoft.graph.concurrency.ICallback;
28+
import com.microsoft.graph.core.ClientException;
29+
import com.microsoft.graph.options.QueryOption;
30+
import com.microsoft.graph.options.Option;
31+
import com.microsoft.graph.core.IBaseClient;
32+
import com.microsoft.graph.http.BaseCollectionRequest;
33+
import com.microsoft.graph.concurrency.IExecutors;
34+
935
<#=CreateClassDef(TypeCollectionRequest(c),"BaseCollectionRequest" + CollectionRequestGeneric(c), ITypeCollectionRequest(c))#>
1036

11-
<# if (c.AsOdcmMethod().IsAction()) { #>
37+
<# if (c.AsOdcmMethod().IsAction() && c.AsOdcmMethod().Parameters.Any()) { #>
1238

1339
protected final <#=TypeBody(c)#> body;
1440

@@ -27,7 +53,7 @@
2753
<# } else { #>
2854
super(requestUrl, client, requestOptions, null);
2955
<# } #>
30-
<# if (c.AsOdcmMethod().IsAction()) { #>
56+
<# if (c.AsOdcmMethod().IsAction() && c.AsOdcmMethod().Parameters.Any()) { #>
3157
body = new <#=TypeBody(c)#>();
3258
<# } #>
3359
}
@@ -49,10 +75,10 @@
4975
}
5076

5177
public <#=ITypeCollectionPage(c)#> post() throws ClientException {
52-
<# if (c.AsOdcmMethod().IsAction()) { #>
78+
<# if (c.AsOdcmMethod().IsAction() && c.AsOdcmMethod().Parameters.Any()) { #>
5379
final <#=TypeCollectionResponse(c)#> response = post(body);
5480
<# } else { #>
55-
final <#=TypeCollectionResponse(c)#> response = post();
81+
final <#=TypeCollectionResponse(c)#> response = super.post(null);
5682
<# } #>
5783
return buildFromResponse(response);
5884
}

Templates/Java/requests_extensions/BaseMethodRequestBuilder.java.tt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,12 @@ import com.microsoft.graph.core.IBaseClient;
1111
import com.microsoft.graph.options.Option;
1212
import com.microsoft.graph.options.FunctionOption;
1313
import com.google.gson.JsonElement;
14+
import com.microsoft.graph.core.<#=RequestBuilderSuperClass(c) #>;
1415

1516
<# bool isAction = !c.AsOdcmMethod().IsFunction; #>
1617
<#=CreateClassDef(TypeRequestBuilder(c), RequestBuilderSuperClass(c), ITypeRequestBuilder(c))#>
1718

18-
<# foreach (var method in c.AsOdcmMethod().WithOverloads()) { #>
19+
<# foreach (var method in c.AsOdcmMethod().WithDistinctOverloads()) { #>
1920
/**
2021
* The request builder for this <#=TypeName(c)#>
2122
*

0 commit comments

Comments
 (0)