Skip to content

Commit 911a038

Browse files
authored
[rel/17.6] Exclude also known resource dlls (#4528)
1 parent 4f929dd commit 911a038

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

src/vstest.console/TestPlatformHelpers/TestRequestManager.cs

+14-4
Original file line numberDiff line numberDiff line change
@@ -1473,23 +1473,29 @@ private static List<string> GetSources(TestRunRequestPayload testRunRequestPaylo
14731473

14741474
internal static class KnownPlatformSourceFilter
14751475
{
1476-
14771476
// Running tests on AzureDevops, many projects use the default filter
14781477
// which includes all *test*.dll, this includes many of the TestPlatform dlls,
14791478
// which we cannot run, and don't want to attempt to run.
14801479
// The default filter also filters out !*TestAdapter*.dll but it is easy to forget
14811480
// so we skip the most used adapters here as well.
14821481
private static readonly HashSet<string> KnownPlatformSources = new(new string[]
14831482
{
1483+
"Microsoft.TestPlatform.AdapterUtilities.dll",
1484+
"Microsoft.TestPlatform.AdapterUtilities.resources.dll",
14841485
"Microsoft.TestPlatform.CommunicationUtilities.dll",
1486+
"Microsoft.TestPlatform.CommunicationUtilities.resources.dll",
14851487
"Microsoft.TestPlatform.CoreUtilities.dll",
1488+
"Microsoft.TestPlatform.CoreUtilities.resources.dll",
14861489
"Microsoft.TestPlatform.CrossPlatEngine.dll",
1490+
"Microsoft.TestPlatform.CrossPlatEngine.resources.dll",
14871491
"Microsoft.TestPlatform.PlatformAbstractions.dll",
14881492
"Microsoft.TestPlatform.Utilities.dll",
1493+
"Microsoft.TestPlatform.Utilities.resources.dll",
14891494
"Microsoft.VisualStudio.TestPlatform.Common.dll",
1495+
"Microsoft.VisualStudio.TestPlatform.Common.resources.dll",
14901496
"Microsoft.VisualStudio.TestPlatform.ObjectModel.dll",
1497+
"Microsoft.VisualStudio.TestPlatform.ObjectModel.resources.dll",
14911498
"testhost.dll",
1492-
"Microsoft.TestPlatform.AdapterUtilities.dll",
14931499

14941500
// NUnit
14951501
"NUnit3.TestAdapter.dll",
@@ -1499,11 +1505,15 @@ internal static class KnownPlatformSourceFilter
14991505
"xunit.runner.visualstudio.dotnetcore.testadapter.dll",
15001506

15011507
// MSTest
1508+
"Microsoft.VisualStudio.TestPlatform.TestFramework.Extensions.dll",
1509+
"Microsoft.VisualStudio.TestPlatform.TestFramework.dll",
1510+
"Microsoft.VisualStudio.TestPlatform.TestFramework.resources.dll",
1511+
// For MSTest up to v3
15021512
"Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.dll",
1513+
"Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.resources.dll",
15031514
"Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.dll",
15041515
"Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.Interface.dll",
1505-
"Microsoft.VisualStudio.TestPlatform.TestFramework.dll",
1506-
"Microsoft.VisualStudio.TestPlatform.TestFramework.Extensions.dll",
1516+
"Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.resources.dll",
15071517
}, StringComparer.OrdinalIgnoreCase);
15081518

15091519

0 commit comments

Comments
 (0)