Skip to content

Rename "Debug" to "Run" #90445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 4 tasks
isidorn opened this issue Feb 11, 2020 · 20 comments
Closed
3 of 4 tasks

Rename "Debug" to "Run" #90445

isidorn opened this issue Feb 11, 2020 · 20 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 11, 2020

Motivation: new users do not know how to run their apps and are not aware that debugging can be used to achieve this when no breakpoints are set or with Debug: start without debugging action.

  • Rename Debug viewlet and top menu bar to "Run"
  • Gather feedback from insiders
  • Look into a user study
  • Investigate into changing the icon - I personally would not do this, since users are very sensitive to changes here. However just in case @misolori has some good idea. The overall notion was that we should experiment play should get visual priority over the bug icon.

Current state

Screenshot 2020-02-10 at 15 48 12

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach labels Feb 11, 2020
@isidorn isidorn added this to the February 2020 milestone Feb 11, 2020
@isidorn isidorn self-assigned this Feb 11, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Feb 11, 2020

@luabud are you maybe planning to do more of the python user studies in the near future? I am asking since we renamed the Debug viewlet to Run and I am wondering if this will have a positive effect.

@luabud
Copy link
Member

luabud commented Feb 11, 2020

@isidorn Definitely! We have one coming up on Feb 20 around the same subject 👍. We'll use VS Code Insiders then 😊.

@miguelsolorio
Copy link
Contributor

I do have an alternate icon (based on @weinand's suggestion) we can use. We can create a custom build for this or enable on Insiders to test this if we want to:

image

@isidorn
Copy link
Contributor Author

isidorn commented Feb 12, 2020

@misolori I actually like that icon. Let's just go crazy and push it to insiders. You only live once. I will handle the haters on GitHub.

@luabud great, let us know how it goes. Thanks a lot!

@weinand
Copy link
Contributor

weinand commented Feb 12, 2020

@misolori Yes, that icon is an excellent start. Could we make the "bug" a tad smaller and its strokes a bit thinner. Similar to the round thing on top of the Terminal (remote Explorer icon):

2020-02-12_12-10-45

@isidorn
Copy link
Contributor Author

isidorn commented Feb 12, 2020

I actually like the current strokes and size so it is larger than the number notification that can appear on the right corner (number of sessions). But we can experiment with different strokes.

@weinand
Copy link
Contributor

weinand commented Feb 12, 2020

We want to convey the message that with this view a user can "Run" the program (corresponding to the newly renamed menu "Run").
Whatever helps to conveys this message is fine by me.
The new icon shows bug and play arrow with the same size, but because the bug sits on top of the arrow, it "dominates" and says "debug".
Having it smaller like the round things in the Remote Explorer icon, would makes it less dominant, and would convey that "Debug" is just an aspect of "Run".

@miguelsolorio
Copy link
Contributor

I can definitely tweak the size and stroke of the bug. I’ll add it to Insiders today.

@isidorn
Copy link
Contributor Author

isidorn commented Feb 12, 2020

Great, thanks!
Makes sense Andre.

@miguelsolorio
Copy link
Contributor

I've tweaked the icon a bit, it was hard to make it smaller as it became tiny in relation to the rest but this was the best I could get to:

This is now in via e4c77cd and should be in tomorrow's Insiders

@isidorn
Copy link
Contributor Author

isidorn commented Feb 13, 2020

Thanks @misolori I just got the new icon. It works for me.
My only complain is that it looks 10% smaller than the other activity bar icons. Is it possible to increase it's size a bit?

@weinand
Copy link
Contributor

weinand commented Feb 13, 2020

yes, increase the size of the arrow (but not the size of the bug).

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Feb 13, 2020

Made the play bigger, see below for before (left) and after (right). I also had to adjust the thickness of the stroke to match the others, before it was a few px above:

@chryw
Copy link
Contributor

chryw commented Feb 14, 2020

I really like the new icon. Speaks two things at once!

@isidorn
Copy link
Contributor Author

isidorn commented Feb 19, 2020

So far feedback has been very positive.
Thus closing this issue.
However we are of course still listening to feedback and are looking forward to the results of the python study.

@isidorn isidorn closed this as completed Feb 19, 2020
@miguelsolorio
Copy link
Contributor

We did a run study last week with 8 participants for Settings Sync and one of the scenarios was to install the Python extension and run a python file. Most went to the terminal to run it, when asked to try an alternate way in the editor they used the "Run" menu. Two noticed the green "play" button and ran it that way, and two others went to the debug viewlet (when asked why they both said they've used the debugger before).

@miguelsolorio
Copy link
Contributor

@luabud let us know if you were able to run any other quick pulse studies that tested the new updates.

@luabud
Copy link
Member

luabud commented Feb 24, 2020

We did! It was with 4 students, 2 went for the "Run" menu at first, and 2 went for the green play button on the top right. When we asked to try an alternate way, two right clicked on the editor, and the other two went for the "Run" menu. On the 3rd time, 3 of them went for the debug viewlet, and one for the run button on the top right - and for this one, the debug viewlet was the 4th alternative.

When we asked about their preference, they all said they preferred the green run button on the top right as it's a one-click solution, and 2 of them mentioned the green colour as being what called their attention.

@isidorn
Copy link
Contributor Author

isidorn commented Feb 26, 2020

@luabud thanks for letting us know and for running this study!
Looking at the results it seems that in this study 3 out of 4 participants went to the debug viewlet to start debugging.
In the previous study 0 out of 4 participants did this.

So there seems to be a postiive effect.

@luabud
Copy link
Member

luabud commented Feb 27, 2020

Yes, definitely!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

5 participants