-
Notifications
You must be signed in to change notification settings - Fork 32.1k
Missing common properties in extension telemetry when logging error event #193205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ignore that my PR is under reviewing for a month (I understand that this issue may not be high priority to dev team), but the issue has been bothering us for a while, and definitely same to other extension developers. Our extension has just been lanuched, so there will be some unhandled errors, of course we want to improve the quality by tracking and fixing them quickly. However current situation is that the error stack has been redacted, and we don't even know the specific version of extension that customer was using, thus is really hard to locate the problem, let alone the root cause 😢 @rebornix Or maybe we should discuss the priority and if there is timeline for the issue firstly... Also I don't blame Logan since he explained that he had a lot of work recently, any other telemetry expert could help on this? |
This should be fixed by microsoft/vscode-extension-telemetry#191 |
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:
@vscode/extension-telemetry
, then use this extension in any other extension, for example we're building Prompt flow for VS Code now.This is not the first issue I submitted, actually I found unsanitized issue before and @lramos15 helped to fixed it. I also learned from his PR then take a deep look today to figure out if this bug is belong to the telemetry extension or the VSCode host. After the investigation, not only submit a issue here, I will also create a PR to fix it ASAP. For more technical details, I will describe in the PR.
The text was updated successfully, but these errors were encountered: