Skip to content

Test Search File Decorations #156195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
andreamah opened this issue Jul 25, 2022 · 2 comments
Closed
3 tasks done

Test Search File Decorations #156195

andreamah opened this issue Jul 25, 2022 · 2 comments
Assignees
Milestone

Comments

@andreamah
Copy link
Contributor

andreamah commented Jul 25, 2022

Refs #115741

Complexity: 1

Create Issue


Set up:

Open up a workspace that has modified and untracked files according to git, in addition to some files that have errors or warnings.

Testing:

Search for a word or phrase that is found in different files that are in a variety states (e.g. modified, untracked, has warnings, has errors).

The color of the search result's file should reflect the state. The rightside icon should express its git status if it's untracked/modified/etc, in addition to the number of errors/warnings if applicable. Essentially, it should have the same decorations as in the file explorer.

It should look something like this:

image

Note: for me, the file explorer looks like:

image

The colors varies based on the color theme. For example, on default dark, modified should be an orange/yellow color and untracked should be green. Regardless, the file colors should match its color in the explorer and "Open Editors" viewlet.

@sadasant
Copy link

[Linux] Looks good to me!

Screen Shot 2022-07-26 at 10 43 07 AM

@bamurtaugh bamurtaugh removed their assignment Jul 26, 2022
@bamurtaugh
Copy link
Member

LGTM!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants