Skip to content

Test command center #150396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
jrieken opened this issue May 25, 2022 · 3 comments
Closed
3 tasks done

Test command center #150396

jrieken opened this issue May 25, 2022 · 3 comments

Comments

@jrieken
Copy link
Member

jrieken commented May 25, 2022

Refs: #149445

Complexity: 3

Create Issue


We have added a quick pick launcher that can be shown in the title bar, aka "Command Center". Please test that

  • window.experimental.commandCenter enables/disables the command center
  • the documentation for the setting points out what's required for the CC to show
  • enabling the CC replaces the "textual window title" with fwd, bwd-buttons and an input-like button
  • the input-like button triggers quick pick
  • its text shows the current workspace name
  • its tooltip shows the full workspace title (as shown when disabling the command center, e.g current file and workspace)
  • its dropdown opens quick pick in "help mode"
  • the CC is centred unless space is tight (enable classic custom menu on win, linux, web)
  • quick pick shows above the title bar when CC is enabled and below when disabled
@yume-chan
Copy link
Contributor

image

Maybe add a placeholder when no folder is open

@bpasero
Copy link
Member

bpasero commented May 31, 2022

Yeah I reported that as #150786

@grumBit
Copy link

grumBit commented Jul 8, 2022

the documentation for the setting points out what's required for the CC to show

I'm not sure if this is the right place to ask, but I'm wondering if the documentation for window.commandCenter needs to include a mention that window.nativeTabs needed to be disabled?

If I'm looking in the correct place, the documentation points out on vs code version 1.69;
image

However, it still didn't show up for me.

I eventually found I needed to disable window.nativeTabs;
image

Which kind of makes sense given "native tabs will disable a custom title bar" in window.nativeTabs description

(PS: Command center looks great! Thank you. 🙏)

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants