Skip to content

Move search app out of renderer into shared process or extension host #118200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bpasero opened this issue Mar 5, 2021 · 3 comments
Closed

Move search app out of renderer into shared process or extension host #118200

bpasero opened this issue Mar 5, 2021 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders sandbox Running VSCode in a node-free environment search Search widget and operation issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@bpasero
Copy link
Member

bpasero commented Mar 5, 2021

We need to remove node dependencies of the renderer for our sandbox effort. Search is currently a process that is triggered from the renderer (via vs/workbench/services/search/electron-browser/searchService et al). Going forward, we should move this into one of the processes that is allowed to execute node:

  • shared process
  • extension host

Filing this to get a discussion starting how to tackle this. With terminals moved, @Tyriar and @meganrogge have demonstrated that the shared process is a viable host for native processes and the patterns used for terminals can be applied to this one as well.

#116337 has a diagram for how the shared process today is being used as host for privileged processes.

@bpasero bpasero added the sandbox Running VSCode in a node-free environment label Mar 5, 2021
@bpasero bpasero changed the title Move search app out of renderer into shared process Move search app out of renderer into shared process or extension host Mar 5, 2021
@bpasero bpasero added the search Search widget and operation issues label Mar 5, 2021
@roblourens
Copy link
Member

It has been the plan for awhile to move this to the EH. I can't find the old discussion about the architecture and the possible perf issues of running search in the EH, but I think this has been proved in Remote, and we can revisit this. @jrieken @kieferrm

@bpasero
Copy link
Member Author

bpasero commented Aug 27, 2021

Would be great if we can push this to stable for the September release given it is now enabled in insiders.

@roblourens roblourens added the feature-request Request for new features or functionality label Aug 27, 2021
@roblourens roblourens added this to the September 2021 milestone Aug 27, 2021
@roblourens roblourens added the verification-needed Verification of issue is requested label Sep 27, 2021
@bpasero
Copy link
Member Author

bpasero commented Sep 28, 2021

I verified the search.forceSearchProcess setting. It needs a restart and we do not tell the user, but my understanding is this setting goes away in October anyway.

@bpasero bpasero added the verified Verification succeeded label Sep 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders sandbox Running VSCode in a node-free environment search Search widget and operation issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants
@roblourens @bpasero and others