Skip to content

Allow users to change type checking problems from 'errors' to 'warnings' (or 'information'). #116261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cagross opened this issue Feb 10, 2021 · 9 comments
Assignees
Labels
languages-diagnostics Source problems reporting typescript Typescript support issues upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@cagross
Copy link

cagross commented Feb 10, 2021

Type checking in VSCode reports type violations at the bottom of the VScode screen--as errors in red in the 'Problems' tab (screenshot). It would be nice to be able to change this to another type of notification (in another color) like warning or information (as in this screenshot).

If this is already possible, can you please let me know how to approach it? I've asked on Stack Overflow (see here), but there were no answers.

In my case, I do not have TypeScript installed in my project, so ignoring these errors will not result in any compile errors for me.
But I have many JSDoc block tags in my code, and I'd like to use VScode's type checking feature to read these and notify me when I call functions with type violations.

The reason I would like this feature is because in many of my project files, as soon I turn on type checking, scores (even hundreds) of type violations suddenly appear in the 'Problems' tab, making it very cluttered. I rely on the Problems tab to notify me of critical errors--those that will result in some error thrown (e.g. parse errors)--so having it cluttered with hundreds of non-crtical notifications reduces its utility. Of course I would like to fix all of the type violations, and I hope to do that at some point. But right now I'm not approved for that :-(

Thanks.

@sandy081
Copy link
Member

/duplicate

@sandy081 sandy081 added the error-list Problems view label Feb 11, 2021
@sandy081
Copy link
Member

#66982

@cagross
Copy link
Author

cagross commented Feb 12, 2021

Thanks for the reply. I see you've marked this as a duplicate to this post. But I had a read, and that looks to be a separate request from mine--one to resolve a separate issue. That request is to allow users to completely clear the entries in Problems tab. I don't want to clear any entries from the Problems tab--I want to see them all. What I want is the option to change the 'designation' (for lack of a better word) of certain entries (the entries from VSCode's type checking feature), from red 'errors' to yellow 'warnings' or white 'information' (as per the icons in this screenshot).

Again, I think the type checking entries in the Problems tab are helpful, and very much want to read/process them. I'd just like to ensure they are displayed as something other than red errors.

Do you still think mine is a duplicate request?

@sandy081
Copy link
Member

Ok I see. Thanks for detail explanation.

These diagnostics are provided by extensions and they own all information of them. Please file an issue against the corresponding extension providing these diagnostics. FYI our CSS extension also provides customization to switch from warning to errors.

@sandy081 sandy081 added *extension-candidate Issue identified as good extension implementation and removed *duplicate Issue identified as a duplicate of another issue(s) labels Feb 12, 2021
@cagross
Copy link
Author

cagross commented Feb 12, 2021

These diagnostics are provided by extensions and they own all information of them

The behavior and issue I am describing are not related to any extension. It pertains to this native VSCode feature: Type checking JavaScript.

FYI our CSS extension also provides customization to switch from warning to errors.

Which extension is that?

@sandy081
Copy link
Member

Assigning to @mjbvz since it is related to TS.

@sandy081 sandy081 reopened this Feb 18, 2021
@sandy081 sandy081 removed *extension-candidate Issue identified as good extension implementation error-list Problems view labels Feb 18, 2021
@sandy081 sandy081 assigned mjbvz and unassigned sandy081 Feb 18, 2021
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 18, 2021

This is tracked upstream by microsoft/TypeScript#13408

It's a long running discussion so if you have something new to add, please share it on that issue

@mjbvz mjbvz closed this as completed Feb 18, 2021
@mjbvz mjbvz added languages-diagnostics Source problems reporting typescript Typescript support issues upstream-issue-linked This is an upstream issue that has been reported upstream labels Feb 18, 2021
@cagross
Copy link
Author

cagross commented Feb 19, 2021

@mjbvz OK thanks for that.

@sandy081 earlier you mentioned, "FYI our CSS extension also provides customization to switch from warning to errors." Can you tell me which CSS extension you are referencing?

@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
languages-diagnostics Source problems reporting typescript Typescript support issues upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

4 participants
@cagross @sandy081 @mjbvz and others