Skip to content

Problem with typescript.tsdk in vscode workspace #106563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asfernandes opened this issue Sep 13, 2020 · 4 comments
Closed

Problem with typescript.tsdk in vscode workspace #106563

asfernandes opened this issue Sep 13, 2020 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@asfernandes
Copy link

asfernandes commented Sep 13, 2020

  • VSCode Version: 1.49.0
  • OS Version: Ubuntu 20.04

I'm trying to configure yarn v2 pnpfy vscode + typescript sdk in a vscode workspace and yarn workspace with multiple projects.

I put typescript.tsdk setting in a relative path of the workspace (".yarn/sdks/typescript/lib" or "./.yarn/sdks/typescript/lib").

When opening vscode workspace and setting the typescript prompt, vscode updates the workspace setting and put the absolute path there. Of course this is not desired.

@asfernandes
Copy link
Author

The automatic change in settings is also happening with yarn v1 too.

I'm sure it didn't happened in old versions as my workspace was using the same setup.

@asfernandes
Copy link
Author

asfernandes commented Sep 13, 2020

Also, the typescript.tsdk setting as I used was prefixed with root/ and root is a folder of the workspace defined as path "." and it's the same. VSCode automatically updates the workspace setting to the absolute path after select the version using the typescript prompt selector.

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 13, 2020

Duplicate of #105202. Should already be fixed in the current insiders builds

@mjbvz mjbvz closed this as completed Sep 13, 2020
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 13, 2020
@karol-pawlowski
Copy link

@mjbvz unfortunately this problem doesn't seem to be solved. I'm using yarn 2.3.1 (which strongly relies on workspace ts settings) in following environment:

Version: 1.49.3 (system setup)
Commit: 2af0510
Date: 2020-10-02T17:57:01.595Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19041

Initial value of mine typescript.tsdk is: "typescript.tsdk": ".yarn/sdks/typescript/lib" and after "select ts to workspace version" it changes to absolute path. It's very not desired behavior, especially because workspace file is under version control.

Worth to mention that, if you update the ts version to workspace one by "typescript.enablePromptUseWorkspaceTsdk": true popup then the path doesn't get updated.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants