Skip to content

Commit ede8a0f

Browse files
committed
Copy extension-provided arrays (#49340)
1 parent ed788cf commit ede8a0f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/vs/workbench/api/node/extHostQuickOpen.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ class ExtHostQuickInput implements QuickInput {
325325
}
326326

327327
set buttons(buttons: QuickInputButton[]) {
328-
this._buttons = buttons;
328+
this._buttons = buttons.slice();
329329
this._handlesToButtons.clear();
330330
buttons.forEach((button, i) => {
331331
const handle = button === backButton ? -1 : i;
@@ -478,7 +478,7 @@ class ExtHostQuickPick extends ExtHostQuickInput implements QuickPick {
478478
}
479479

480480
set items(items: QuickPickItem[]) {
481-
this._items = items;
481+
this._items = items.slice();
482482
this._handlesToItems.clear();
483483
this._itemsToHandles.clear();
484484
items.forEach((item, i) => {

0 commit comments

Comments
 (0)