compositePart should use createActionViewItem helper

sbatten · sbatten · commit e22707465173 · 2022-01-26T15:21:50.000-08:00
fixes #141399
diff --git a/src/vs/workbench/browser/parts/compositePart.ts b/src/vs/workbench/browser/parts/compositePart.ts
@@ -31,6 +31,7 @@ import { INotificationService } from 'vs/platform/notification/common/notificati
 import { Dimension, append, $, hide, show } from 'vs/base/browser/dom';
 import { AnchorAlignment } from 'vs/base/browser/ui/contextview/contextview';
 import { assertIsDefined, withNullAsUndefined } from 'vs/base/common/types';
+import { createActionViewItem } from 'vs/platform/actions/browser/menuEntryActionViewItem';
 
 export interface ICompositeTitleLabel {
 
@@ -436,7 +437,7 @@ export abstract class CompositePart<T extends Composite> extends Part {
 			return this.activeComposite.getActionViewItem(action);
 		}
 
-		return undefined;
+		return createActionViewItem(this.instantiationService, action);
 	}
 
 	protected actionsContextProvider(): unknown {

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ import { INotificationService } from 'vs/platform/notification/common/notificati`
`31`	`31`	`import { Dimension, append, $, hide, show } from 'vs/base/browser/dom';`
`32`	`32`	`import { AnchorAlignment } from 'vs/base/browser/ui/contextview/contextview';`
`33`	`33`	`import { assertIsDefined, withNullAsUndefined } from 'vs/base/common/types';`
	`34`	`+import { createActionViewItem } from 'vs/platform/actions/browser/menuEntryActionViewItem';`
`34`	`35`
`35`	`36`	`export interface ICompositeTitleLabel {`
`36`	`37`
`@@ -436,7 +437,7 @@ export abstract class CompositePart<T extends Composite> extends Part {`
`436`	`437`	`return this.activeComposite.getActionViewItem(action);`
`437`	`438`	`}`
`438`	`439`
`439`		`- return undefined;`
	`440`	`+ return createActionViewItem(this.instantiationService, action);`
`440`	`441`	`}`
`441`	`442`
`442`	`443`	`protected actionsContextProvider(): unknown {`