Skip to content

Commit d88ac6f

Browse files
committed
Finalize the isWritableFileSystem API
Fixes #91697
1 parent d54c3c6 commit d88ac6f

File tree

2 files changed

+15
-22
lines changed

2 files changed

+15
-22
lines changed

src/vs/vscode.d.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6860,6 +6860,21 @@ declare module 'vscode' {
68606860
* @param options Defines if existing files should be overwritten.
68616861
*/
68626862
copy(source: Uri, target: Uri, options?: { overwrite?: boolean }): Thenable<void>;
6863+
6864+
/**
6865+
* Check if a given file system supports writing files.
6866+
*
6867+
* Keep in mind that just because a file system supports writing, that does
6868+
* not mean that writes will always succeed. There may be permissions issues
6869+
* or other errors that prevent writing a file.
6870+
*
6871+
* @param scheme The scheme of the filesystem, for example `file` or `git`.
6872+
*
6873+
* @return `true` if the file system supports writing, `false` if it does not
6874+
* support writing (i.e. it is readonly), and `undefined` if VS Code does not
6875+
* know about the filesystem.
6876+
*/
6877+
isWritableFileSystem(scheme: string): boolean | undefined;
68636878
}
68646879

68656880
/**

src/vs/vscode.proposed.d.ts

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2141,28 +2141,6 @@ declare module 'vscode' {
21412141
}
21422142
//#endregion
21432143

2144-
//#region https://github.com/microsoft/vscode/issues/91697
2145-
2146-
export interface FileSystem {
2147-
/**
2148-
* Check if a given file system supports writing files.
2149-
*
2150-
* Keep in mind that just because a file system supports writing, that does
2151-
* not mean that writes will always succeed. There may be permissions issues
2152-
* or other errors that prevent writing a file.
2153-
*
2154-
* @param scheme The scheme of the filesystem, for example `file` or `git`.
2155-
*
2156-
* @return `true` if the file system supports writing, `false` if it does not
2157-
* support writing (i.e. it is readonly), and `undefined` if VS Code does not
2158-
* know about the filesystem.
2159-
*/
2160-
isWritableFileSystem(scheme: string): boolean | undefined;
2161-
}
2162-
2163-
2164-
//#endregion
2165-
21662144
//#region https://github.com/microsoft/vscode/issues/108929 FoldingRangeProvider.onDidChangeFoldingRanges @aeschli
21672145
export interface FoldingRangeProvider2 extends FoldingRangeProvider {
21682146

0 commit comments

Comments
 (0)