Skip to content

Commit a6833ed

Browse files
authored
proper fix for #105202 (#106293)
1 parent e969bc1 commit a6833ed

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

extensions/typescript-language-features/src/tsServer/versionManager.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
import * as vscode from 'vscode';
77
import * as nls from 'vscode-nls';
8-
import * as path from 'path';
98
import { TypeScriptServiceConfiguration } from '../utils/configuration';
109
import { Disposable } from '../utils/dispose';
1110
import { ITypeScriptVersionProvider, TypeScriptVersion } from './versionProvider';
@@ -110,7 +109,7 @@ export class TypeScriptVersionManager extends Disposable {
110109
run: async () => {
111110
await this.workspaceState.update(useWorkspaceTsdkStorageKey, true);
112111
const tsConfig = vscode.workspace.getConfiguration('typescript');
113-
await tsConfig.update('tsdk', path.dirname(version.tsServerPath), false);
112+
await tsConfig.update('tsdk', version.pathLabel, false);
114113
this.updateActiveVersion(version);
115114
},
116115
};

extensions/typescript-language-features/src/tsServer/versionProvider.electron.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,8 @@ export class DiskTypeScriptVersionProvider implements ITypeScriptVersionProvider
104104
return [
105105
new TypeScriptVersion(source,
106106
serverPath,
107-
DiskTypeScriptVersionProvider.getApiVersion(serverPath))
107+
DiskTypeScriptVersionProvider.getApiVersion(serverPath),
108+
tsdkPathSetting)
108109
];
109110
}
110111

0 commit comments

Comments
 (0)