Allow user tasks to run when no folder is open

Author: alexr00

src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts

@@ -40,7 +40,7 @@ import { IPanelService } from 'vs/workbench/services/panel/common/panelService';
 import Constants from 'vs/workbench/contrib/markers/browser/constants';
 import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
 import { IConfigurationResolverService } from 'vs/workbench/services/configurationResolver/common/configurationResolver';
-import { IWorkspaceContextService, WorkbenchState, IWorkspaceFolder, IWorkspace } from 'vs/platform/workspace/common/workspace';
+import { IWorkspaceContextService, WorkbenchState, IWorkspaceFolder, IWorkspace, WorkspaceFolder } from 'vs/platform/workspace/common/workspace';
 
 import { ITextFileService } from 'vs/workbench/services/textfile/common/textfiles';
 import { IOutputService, IOutputChannel } from 'vs/workbench/contrib/output/common/output';
@@ -1702,7 +1702,7 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
 						return;
 					}
 
-					if (!contributed) {
+					if (contributed.length === 0) {
 						result.add(key, ...folderTasks.set.tasks);
 					} else {
 						let configurations = folderTasks.configurations;
@@ -1867,31 +1867,35 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
 	protected abstract updateWorkspaceTasks(runSource: TaskRunSource | void): void;
 
 	protected computeWorkspaceTasks(runSource: TaskRunSource = TaskRunSource.User): Promise<Map<string, WorkspaceFolderTaskResult>> {
-		if (this.workspaceFolders.length === 0) {
-			return Promise.resolve(new Map<string, WorkspaceFolderTaskResult>());
-		} else {
-			let promises: Promise<WorkspaceFolderTaskResult | undefined>[] = [];
-			for (let folder of this.workspaceFolders) {
-				promises.push(this.computeWorkspaceFolderTasks(folder, runSource).then((value) => value, () => undefined));
-			}
-			return Promise.all(promises).then(async (values) => {
-				let result = new Map<string, WorkspaceFolderTaskResult>();
-				for (let value of values) {
-					if (value) {
-						result.set(value.workspaceFolder.uri.toString(), value);
-					}
-				}
-				const userTasks = await this.computeUserTasks(this.workspaceFolders[0], runSource).then((value) => value, () => undefined);
-				if (userTasks) {
-					result.set(USER_TASKS_GROUP_KEY, userTasks);
+		let promises: Promise<WorkspaceFolderTaskResult | undefined>[] = [];
+		for (let folder of this.workspaceFolders) {
+			promises.push(this.computeWorkspaceFolderTasks(folder, runSource).then((value) => value, () => undefined));
+		}
+		return Promise.all(promises).then(async (values) => {
+			let result = new Map<string, WorkspaceFolderTaskResult>();
+			for (let value of values) {
+				if (value) {
+					result.set(value.workspaceFolder.uri.toString(), value);
 				}
-				const workspaceFileTasks = await this.computeWorkspaceFileTasks(this.workspaceFolders[0], runSource).then((value) => value, () => undefined);
+			}
+			let folder = this.workspaceFolders.length > 0 ? this.workspaceFolders[0] : undefined;
+			if (!folder) {
+				const userhome = await this.pathService.userHome();
+				folder = new WorkspaceFolder({ uri: userhome, name: resources.basename(userhome), index: 0 });
+			}
+			const userTasks = await this.computeUserTasks(folder, runSource).then((value) => value, () => undefined);
+			if (userTasks) {
+				result.set(USER_TASKS_GROUP_KEY, userTasks);
+			}
+
+			if (this.contextService.getWorkbenchState() !== WorkbenchState.EMPTY) {
+				const workspaceFileTasks = await this.computeWorkspaceFileTasks(folder, runSource).then((value) => value, () => undefined);
 				if (workspaceFileTasks && this._workspace && this._workspace.configuration) {
 					result.set(this._workspace.configuration.toString(), workspaceFileTasks);
 				}
-				return result;
-			});
-		}
+			}
+			return result;
+		});
 	}
 
 	private get jsonTasksSupported(): boolean {
@@ -2167,17 +2171,6 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
 	}
 
 	private canRunCommand(): boolean {
-		if (this.contextService.getWorkbenchState() === WorkbenchState.EMPTY) {
-			this.notificationService.prompt(
-				Severity.Info,
-				nls.localize('TaskService.noWorkspace', "Tasks are only available on a workspace folder."),
-				[{
-					label: nls.localize('TaskService.learnMore', "Learn More"),
-					run: () => this.openerService.open(URI.parse('https://code.visualstudio.com/docs/editor/tasks'))
-				}]
-			);
-			return false;
-		}
 		return true;
 	}
 
@@ -2871,8 +2864,13 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
 		}
 		if (this.isTaskEntry(selection)) {
 			this.configureTask(selection.task);
-		} else {
+		} else if (this.contextService.getWorkbenchState() !== WorkbenchState.EMPTY) {
 			this.openTaskFile(selection.folder.toResource('.vscode/tasks.json'), TaskSourceKind.Workspace);
+		} else {
+			const resource = this.getResourceForKind(TaskSourceKind.User);
+			if (resource) {
+				this.openTaskFile(resource, TaskSourceKind.User);
+			}
 		}
 	}
 
@@ -2914,46 +2912,22 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
 			return taskPromise.then((taskMap) => {
 				let entries: QuickPickInput<TaskQuickPickEntryType>[] = [];
 				let needsCreateOrOpen: boolean = true;
-				if (this.contextService.getWorkbenchState() !== WorkbenchState.EMPTY) {
-					let tasks = taskMap.all();
-					if (tasks.length > 0) {
-						tasks = tasks.sort((a, b) => a._label.localeCompare(b._label));
-						for (let task of tasks) {
-							entries.push({ label: task._label, task, description: this.getTaskDescription(task), detail: this.showDetail() ? task.configurationProperties.detail : undefined });
-							if (!ContributedTask.is(task)) {
-								needsCreateOrOpen = false;
-							}
-						}
-					}
-					if (needsCreateOrOpen) {
-						let label = stats[0] !== undefined ? openLabel : createLabel;
-						if (entries.length) {
-							entries.push({ type: 'separator' });
+				let tasks = taskMap.all();
+				if (tasks.length > 0) {
+					tasks = tasks.sort((a, b) => a._label.localeCompare(b._label));
+					for (let task of tasks) {
+						entries.push({ label: task._label, task, description: this.getTaskDescription(task), detail: this.showDetail() ? task.configurationProperties.detail : undefined });
+						if (!ContributedTask.is(task)) {
+							needsCreateOrOpen = false;
 						}
-						entries.push({ label, folder: this.contextService.getWorkspace().folders[0] });
 					}
-				} else {
-					let folders = this.contextService.getWorkspace().folders;
-					let index = 0;
-					for (let folder of folders) {
-						let tasks = taskMap.get(folder);
-						if (tasks.length > 0) {
-							tasks = tasks.slice().sort((a, b) => a._label.localeCompare(b._label));
-							for (let i = 0; i < tasks.length; i++) {
-								let entry: TaskQuickPickEntryType = { label: tasks[i]._label, task: tasks[i], description: this.getTaskDescription(tasks[i]) };
-								if (i === 0) {
-									entries.push({ type: 'separator', label: folder.name });
-								}
-								entries.push(entry);
-							}
-						} else {
-							let label = stats[index] !== undefined ? openLabel : createLabel;
-							let entry: TaskQuickPickEntryType = { label, folder: folder };
-							entries.push({ type: 'separator', label: folder.name });
-							entries.push(entry);
-						}
-						index++;
+				}
+				if (needsCreateOrOpen) {
+					let label = stats[0] !== undefined ? openLabel : createLabel;
+					if (entries.length) {
+						entries.push({ type: 'separator' });
 					}
+					entries.push({ label, folder: this.contextService.getWorkspace().folders[0] });
 				}
 				if ((entries.length === 1) && !needsCreateOrOpen) {
 					tokenSource.cancel();