Added error telemetry for query plans (#19417)

* added error telemetry

* pr comments + fixed test

* fix unit test

---------

Co-authored-by: Lauren Nathan <[email protected]>

Author: laurenastrid1

src/controllers/sharedExecutionPlanUtils.ts

@@ -16,7 +16,7 @@ import * as vscode from "vscode";
 import UntitledSqlDocumentService from "./untitledSqlDocumentService";
 import { ApiStatus } from "../sharedInterfaces/webview";
 import { TelemetryActions, TelemetryViews } from "../sharedInterfaces/telemetry";
-import { sendActionEvent } from "../telemetry/telemetry";
+import { sendActionEvent, sendErrorEvent } from "../telemetry/telemetry";
 import { sqlPlanLanguageId } from "../constants/constants";
 import { executionPlanFileFilter } from "../constants/locConstants";
 
@@ -104,9 +104,18 @@ export async function createExecutionPlanGraphs(
             );
             newState.loadState = ApiStatus.Loaded;
         } catch (e) {
-            // malformed xml
+            // Errors out on first instance of malformed xml
             newState.loadState = ApiStatus.Error;
             newState.errorMessage = getErrorMessage(e);
+            state.executionPlanState = newState;
+
+            sendErrorEvent(
+                TelemetryViews.ExecutionPlan,
+                TelemetryActions.OpenExecutionPlan,
+                e,
+                true, // includeErrorMessage
+            );
+            return state;
         }
     }
 

test/unit/executionPlanWebviewController.test.ts

@@ -363,7 +363,7 @@ suite("Execution Plan Utilities", () => {
 
         sinon.assert.calledOnceWithExactly(getExecutionPlanStub, planFile);
 
-        assert.notEqual(result, undefined, "The resulting state should be defined");
+        assert.notDeepEqual(result, undefined, "The resulting state should be defined");
         assert.deepStrictEqual(
             result.executionPlanState.loadState,
             ApiStatus.Error,