Skip to content

Commit 8a1a442

Browse files
Update tp to solve the dependencies issue (#1053)
* Update tp to solve the dependencies issue * Upgrade to node 20 * Add 'shell: true' option before running cp.spawn in Windows
1 parent 3c6f598 commit 8a1a442

File tree

5 files changed

+7
-35
lines changed

5 files changed

+7
-35
lines changed

.github/workflows/linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
- name: Setup Node.js environment
2929
uses: actions/setup-node@v2
3030
with:
31-
node-version: 16
31+
node-version: 20
3232

3333
- name: Install Node.js modules
3434
run: npm install

.github/workflows/macOS.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: Setup Node.js environment
2323
uses: actions/setup-node@v2
2424
with:
25-
node-version: 16
25+
node-version: 20
2626

2727
- name: Install Node.js modules
2828
run: npm install

.github/workflows/windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: Setup Node.js environment
2323
uses: actions/setup-node@v2
2424
with:
25-
node-version: 16
25+
node-version: 20
2626

2727
- name: Install Node.js modules
2828
run: npm install
Lines changed: 2 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,13 @@
1-
<?xml version="1.0" encoding="UTF-8" standalone="no"?><?pde version="3.8"?><target name="JDTLS.EXT" sequenceNumber="38">
1+
<?xml version="1.0" encoding="UTF-8" standalone="no"?><?pde version="3.8"?>
2+
<target name="JDTLS.EXT" sequenceNumber="38">
23
<locations>
3-
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
4-
<unit id="org.eclipse.equinox.core.feature.feature.group" version="0.0.0"/>
5-
<unit id="org.eclipse.equinox.core.sdk.feature.group" version="0.0.0"/>
6-
<unit id="org.eclipse.equinox.executable.feature.group" version="0.0.0"/>
7-
<unit id="org.eclipse.equinox.p2.core.feature.source.feature.group" version="0.0.0"/>
8-
<unit id="org.eclipse.equinox.sdk.feature.group" version="0.0.0"/>
9-
<unit id="org.eclipse.jdt.source.feature.group" version="0.0.0"/>
10-
<unit id="org.eclipse.sdk.feature.group" version="0.0.0"/>
11-
<unit id="org.mockito.mockito-core" version="0.0.0"/>
12-
<repository location="https://download.eclipse.org/eclipse/updates/4.33-I-builds/I20240613-1800/"/>
13-
</location>
14-
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
15-
<unit id="org.eclipse.xtext.xbase.lib" version="0.0.0"/>
16-
<unit id="com.google.gson" version="2.10.1.v20230109-0753"/>
17-
<repository location="https://download.eclipse.org/releases/2024-03/"/>
18-
</location>
194
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
205
<unit id="org.eclipse.jdt.ls.core" version="0.0.0"/>
216
<repository location="https://download.eclipse.org/jdtls/snapshots/repository/latest/"/>
227
</location>
23-
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
24-
<repository location="https://download.eclipse.org/lsp4j/updates/releases/0.22.0/"/>
25-
<unit id="org.eclipse.lsp4j" version="0.0.0"/>
26-
</location>
278
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
289
<unit id="org.eclipse.m2e.maven.runtime" version="0.0.0"/>
2910
<repository location="https://download.eclipse.org/technology/m2e/snapshots/latest/"/>
3011
</location>
31-
<location includeDependencyDepth="none" includeDependencyScopes="compile" includeSource="true" missingManifest="generate" type="Maven">
32-
<dependencies>
33-
<dependency>
34-
<groupId>org.apache.commons</groupId>
35-
<artifactId>commons-lang3</artifactId>
36-
<version>3.14.0</version>
37-
<type>jar</type>
38-
</dependency>
39-
</dependencies>
40-
</location>
4112
</locations>
4213
</target>

test/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ async function main(): Promise<void> {
1313
const [cli, ...args] = resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath);
1414
cp.spawnSync(cli, [...args, '--install-extension', 'redhat.java'], {
1515
encoding: 'utf-8',
16-
stdio: 'inherit'
16+
stdio: 'inherit',
17+
shell: process.platform === "win32",
1718
});
1819

1920
// The folder containing the Extension Manifest package.json

0 commit comments

Comments
 (0)