-
Notifications
You must be signed in to change notification settings - Fork 325
Shift + Enter does not run a cell on native notebook #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Extremely strong upvote to this one. The absolute first thing any user tries is broken (from the user's point of view). Doubly bad because, as far as I can tell, there doesn't even exist an action (!) for "execute cell and put cursor in next cell and/or make a new one" which is the default behavior in Jupyter itself. The user literally has to choose one of these two workflows as a replacement for Shift+Enter:
Keep in mind that these workarounds are replacements for literally the most commonly executed keyboard shortcut in all of Jupyter, by a long shot. I realize I'm being a bit blunt, but my mind boggles at a UX decision like this. It's like putting the steering wheel in the glove compartment. |
Okay actually it looks like this might be caused by the shift+enter from the python extension stealing shift+enter. |
And this is not by design. It wasn't a conscious choice. |
Glad to hear it! :) So is the easy workaround to turn off that keyboard shortcut in the Python extension? |
Yes if you disable the shift+enter on the python extension, the keystroke is not stolen. |
Excellent, I just confirmed that works. Thanks for the super-fast reply! |
Of course, I'm sure you're still interested in making sure that Shift+Enter works without this workaround, because in an educational context (where I work) you want first-time users (students) to just drop in and it works. But this is great in the interim. |
We need to detect if shift-enter is being invoked in the context of a native notebook. |
Uh oh!
There was an error while loading. Please reload this page.
It can run a cell in the terminal or do nothing.
Repro steps:
Expected behaviour
Cell executes
Actual behaviour
Nothing or it executes the cell in the terminal (cause python extension gets the shift+enter)
Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]
Logs
Output for
Jupyter
in theOutput
panel (View
→Output
, change the drop-down the upper-right of theOutput
panel toJupyter
)The text was updated successfully, but these errors were encountered: