refactor: rm node.children check

zjffun · zjffun · commit 7cd68afb0f8b · 2022-01-15T15:17:58.000+08:00
diff --git a/packages/vscode-js-profile-core/src/heap/editorProvider.ts b/packages/vscode-js-profile-core/src/heap/editorProvider.ts
@@ -40,9 +40,7 @@ export class HeapProfileEditorProvider
       const node = nodes.pop();
       if (node) {
         treeNodes.push(node);
-        if (node.children) {
-          nodes = nodes.concat(Object.values(node.children));
-        }
+        nodes = nodes.concat(Object.values(node.children));
       }
     }
 
diff --git a/packages/vscode-js-profile-core/src/heap/model.ts b/packages/vscode-js-profile-core/src/heap/model.ts
@@ -67,9 +67,7 @@ export const buildModel = (profile: IHeapProfileRaw): IProfileModel => {
           sourceReference: 0,
         },
       };
-      if (node.children) {
-        nodes = nodes.concat(node.children);
-      }
+      nodes = nodes.concat(node.children);
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -40,9 +40,7 @@ export class HeapProfileEditorProvider`
`40`	`40`	`const node = nodes.pop();`
`41`	`41`	`if (node) {`
`42`	`42`	`treeNodes.push(node);`
`43`		`- if (node.children) {`
`44`		`- nodes = nodes.concat(Object.values(node.children));`
`45`		`- }`
	`43`	`+ nodes = nodes.concat(Object.values(node.children));`
`46`	`44`	`}`
`47`	`45`	`}`
`48`	`46`
Original file line number	Diff line number	Diff line change
`@@ -67,9 +67,7 @@ export const buildModel = (profile: IHeapProfileRaw): IProfileModel => {`
`67`	`67`	`sourceReference: 0,`
`68`	`68`	`},`
`69`	`69`	`};`
`70`		`- if (node.children) {`
`71`		`- nodes = nodes.concat(node.children);`
`72`		`- }`
	`70`	`+ nodes = nodes.concat(node.children);`
`73`	`71`	`}`
`74`	`72`	`}`
`75`	`73`